Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor updates to Dockerfile #38

Closed
wants to merge 1 commit into from
Closed

minor updates to Dockerfile #38

wants to merge 1 commit into from

Conversation

felixkrohn
Copy link

  • use more recent of builder image
  • use explicit registry name in image sources
  • add "shards update" call to Dockerfile (works for me... not a crystal expert)
  • chain 2 commands together to reduce amount of layers

@felixkrohn
minor updates to Dockerfile
40b52be 
* use more recent of builder image
* use explicit registry name in image sources
* add "shards update" call (works for me... not a crystal expert)
* chain 2 commands together to reduce amount of layers
@felixkrohn felixkrohn mentioned this pull request Nov 14, 2022
Open
JayVii
JayVii reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@JayVii JayVii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear this PR is obsolete by now, as all proposed changes have been implemented already in the menatime

Dockerfile
@@ -1,19 +1,18 @@
FROM crystallang/crystal:1.2.2-alpine AS builder
FROM docker.io/crystallang/crystal:1.6.2-alpine AS builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete due to 29f45a0

Dockerfile
RUN apk update && apk upgrade && apk add sqlite-static
WORKDIR /build/
ARG version
RUN git clone --branch ${version:-dist} --depth 1 https://github.com/toddsundsted/ktistec .
RUN shards install --production
RUN shards update && shards install --production
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemented in 648b463

@felixkrohn
Copy link
Author

felixkrohn commented Nov 7, 2024 •
edited
Loading

@JayVii you're right, thanks.

@felixkrohn felixkrohn closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayVii JayVii JayVii left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixkrohn @JayVii