Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the task's name and uses as default #249

Merged
merged 4 commits into from
Mar 26, 2018

Conversation

guifeliper
Copy link
Contributor

@guifeliper guifeliper commented Mar 23, 2018

Read the task's name and uses as default, so the user can read the previous task's name.
This commit is an answer to the issue #245.

Fixes #245

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #245 reference to the issue that this pull request fixes.

Copy link
Member

@inkarkat inkarkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least in my Bash 4.3.48(1)-release, the variable (input) needs to come last:

-bash: read: `-r': not a valid identifier

@guifeliper
Copy link
Contributor Author

@inkarkat you seem to be right, my local version is
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin16)

The version of GNU bash, version 4.4.5(1)-release has the same behaviour you mentioned above.
I suggest we use
read -r -i $todo -e input

@karbassi karbassi added this to the Version 2.12.0 milestone Mar 26, 2018
@karbassi
Copy link
Member

@inkarkat thoughts on this merge? Is it good to go with @guifeliper's updates?

@karbassi karbassi changed the title (fix #245) Read the task's name and uses as default Read the task's name and uses as default Mar 26, 2018
@karbassi karbassi merged commit 7ec2a12 into todotxt:master Mar 26, 2018
wwalker pushed a commit to wwalker/todo.txt-cli that referenced this pull request Sep 19, 2021
Read the task's name and uses as default, so the user can read the previous task's name.

Thanks @guifeliper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tab completion for replace fills in wrong text
3 participants