ENH: Enable file completion for add-on actions via _todo_file{1,2,3}_actions #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r actions taking a SRC argument Making it consistent with the test for MOVE_COMMAND_PATTERN, and allowing to extend the pattern with custom actions in the future.
So that additional (custom) add-on actions can be configured in the future.
…actions Allowing completion of todo files directly after the add-on action (1), with one (2) / two (3) arguments in between. This should handle most cases. In order to configure the add-on completion, the corresponding configuration variable has to be defined in the user's shell (e.g. via ~/.bashrc): _todo_file1_actions='myaction|anotheraction'
karbassi
requested changes
Mar 18, 2019
karbassi
approved these changes
Mar 25, 2019
|
@inkarkat if you could resolve the conflict and see if tests pass, maybe we can merge this. |
|
@karbassi Alright, merged in the indentation changes. Tests pass. |
wwalker
pushed a commit
to wwalker/todo.txt-cli
that referenced
this pull request
Sep 19, 2021
…actions (todotxt#270) * Refactoring: Use regular expression match instead of case globbing for actions taking a SRC argument Making it consistent with the test for MOVE_COMMAND_PATTERN, and allowing to extend the pattern with custom actions in the future. * Refactoring: Move the anchoring and grouping out of MOVE_COMMAND_PATTERN So that additional (custom) add-on actions can be configured in the future. * ENH: Enable file completion for add-on actions via _todo_file{1,2,3}_actions Allowing completion of todo files directly after the add-on action (1), with one (2) / two (3) arguments in between. This should handle most cases. In order to configure the add-on completion, the corresponding configuration variable has to be defined in the user's shell (e.g. via ~/.bashrc): _todo_file1_actions='myaction|anotheraction'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done:
master.fixes #XXreference to the issue that this pull request fixes. Addresses the issue raised in Bash completion with add on actions #269