Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): app height exceeds viewport of mobile #7706

Merged

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Aug 2, 2024

TL;DR
use 100dvh instead of 100vh.

https://stackoverflow.com/a/72245072

PS: The 100dvh is tested in Firefox in macOS

Before

iPad

Phone

After

iPad

Phone

Copy link

graphite-app bot commented Aug 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

L-Sun commented Aug 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @L-Sun and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 2, 2024

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.54%. Comparing base (e3878ae) to head (545bd03).

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7706       +/-   ##
===========================================
- Coverage   55.33%   26.54%   -28.79%     
===========================================
  Files        1003      795      -208     
  Lines       43396    19505    -23891     
  Branches     5182     3630     -1552     
===========================================
- Hits        24013     5178    -18835     
+ Misses      19022    14019     -5003     
+ Partials      361      308       -53     
Flag Coverage Δ
server-test ?
unittest 26.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L-Sun L-Sun marked this pull request as ready for review August 2, 2024 07:42
Copy link

graphite-app bot commented Aug 5, 2024

Merge activity

@L-Sun L-Sun force-pushed the 08-02-fix_core_app_height_exceeds_viewport_of_mobile branch from ccd4149 to 545bd03 Compare August 5, 2024 03:42
@graphite-app graphite-app bot merged commit 545bd03 into canary Aug 5, 2024
33 checks passed
@graphite-app graphite-app bot deleted the 08-02-fix_core_app_height_exceeds_viewport_of_mobile branch August 5, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants