Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): tuning for better search #7713

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Aug 2, 2024

No description provided.

Copy link

graphite-app bot commented Aug 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review August 2, 2024 10:43
Copy link
Member Author

EYHN commented Aug 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:infra Environment related issues and discussions test Related to test cases app:core labels Aug 2, 2024
Copy link

nx-cloud bot commented Aug 2, 2024

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.38%. Comparing base (ad26102) to head (f108b95).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           eyhn/fix/scroll-into    #7713       +/-   ##
=========================================================
+ Coverage                 26.52%   55.38%   +28.86%     
=========================================================
  Files                       792     1000      +208     
  Lines                     19477    43368    +23891     
  Branches                   3620     5173     +1553     
=========================================================
+ Hits                       5166    24019    +18853     
- Misses                    14005    18990     +4985     
- Partials                    306      359       +53     
Flag Coverage Δ
server-test 78.91% <ø> (?)
unittest 26.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 5, 2024

Merge activity

@EYHN EYHN changed the base branch from eyhn/fix/scroll-into to canary August 5, 2024 02:42
@graphite-app graphite-app bot merged commit f108b95 into canary Aug 5, 2024
33 checks passed
@graphite-app graphite-app bot deleted the eyhn/tuning-search branch August 5, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:infra Environment related issues and discussions test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants