Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): adjust app-tabs-header styles #7961

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Aug 23, 2024

image.png

image.png

image.png

also fix PD-1631

Copy link

graphite-app bot commented Aug 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Aug 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review August 23, 2024 10:18
@graphite-app graphite-app bot requested review from EYHN, JimmFly, CatsJuice and forehalo and removed request for JimmFly August 23, 2024 10:18
@pengx17 pengx17 requested review from zanwei and removed request for EYHN, CatsJuice and forehalo August 23, 2024 10:18
Copy link

nx-cloud bot commented Aug 23, 2024

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.27%. Comparing base (bc86f0a) to head (611925f).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7961   +/-   ##
=======================================
  Coverage   55.27%   55.27%           
=======================================
  Files        1060     1060           
  Lines       44725    44725           
  Branches     5272     5272           
=======================================
  Hits        24722    24722           
  Misses      19624    19624           
  Partials      379      379           
Flag Coverage Δ
server-test 77.68% <ø> (ø)
unittest 27.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 08-23-fix_electron_adjust_app-tabs-header_styles branch from d945ab2 to e84843a Compare August 23, 2024 12:02
Copy link

graphite-app bot commented Aug 26, 2024

Merge activity

@pengx17 pengx17 force-pushed the 08-23-fix_electron_adjust_app-tabs-header_styles branch from e84843a to 611925f Compare August 26, 2024 09:34
@graphite-app graphite-app bot merged commit 611925f into canary Aug 26, 2024
33 checks passed
@graphite-app graphite-app bot deleted the 08-23-fix_electron_adjust_app-tabs-header_styles branch August 26, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants