Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add new doc default mode setting #7990

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Aug 27, 2024

close AF-1287

CleanShot.2024-08-27.at.16.30.34.mp4

Copy link

graphite-app bot commented Aug 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

nx-cloud bot commented Aug 27, 2024

@JimmFly JimmFly changed the title chore: adjust slider style chore: add Aug 27, 2024
@JimmFly JimmFly changed the title chore: add feat(core): add new doc default mode setting Aug 27, 2024
@JimmFly JimmFly marked this pull request as ready for review August 27, 2024 07:47
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 55.24%. Comparing base (c53adbc) to head (09ab922).
Report is 2 commits behind head on canary.

Files Patch % Lines
...src/components/page-list/docs/page-list-header.tsx 0.00% 11 Missing ⚠️
...ponents/blocksuite/block-suite-page-list/utils.tsx 0.00% 6 Missing ⚠️
...omponents/page-list/components/new-page-button.tsx 0.00% 5 Missing ⚠️
.../src/modules/explorer/views/nodes/folder/index.tsx 0.00% 3 Missing ⚠️
...odules/explorer/views/sections/favorites/index.tsx 0.00% 3 Missing ⚠️
...d/core/src/components/page-list/operation-cell.tsx 0.00% 2 Missing ⚠️
...les/explorer/views/nodes/collection/operations.tsx 0.00% 2 Missing ⚠️
...rc/modules/explorer/views/nodes/doc/operations.tsx 0.00% 2 Missing ⚠️
...rc/modules/explorer/views/nodes/tag/operations.tsx 0.00% 2 Missing ⚠️
...ges/frontend/core/src/commands/affine-creation.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7990      +/-   ##
==========================================
+ Coverage   55.22%   55.24%   +0.02%     
==========================================
  Files        1060     1060              
  Lines       44733    44749      +16     
  Branches     5273     5276       +3     
==========================================
+ Hits        24705    24723      +18     
+ Misses      19647    19645       -2     
  Partials      381      381              
Flag Coverage Δ
server-test 77.68% <ø> (+0.07%) ⬆️
unittest 27.11% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/0827/add-new-doc-edfault-mode branch 2 times, most recently from 02e9d49 to 44151f7 Compare August 27, 2024 07:58
@JimmFly JimmFly force-pushed the jimmfly/0827/add-new-doc-edfault-mode branch from 44151f7 to 04f2c53 Compare August 27, 2024 08:15
@JimmFly JimmFly requested a review from pengx17 August 27, 2024 09:19
@JimmFly JimmFly requested a review from pengx17 August 27, 2024 09:50
@JimmFly JimmFly force-pushed the jimmfly/0827/add-new-doc-edfault-mode branch from 7fc29f9 to cc9365f Compare August 27, 2024 15:48
Copy link

graphite-app bot commented Aug 28, 2024

Merge activity

@EYHN EYHN force-pushed the jimmfly/0827/adjust-style branch from ee9c695 to c53adbc Compare August 28, 2024 02:36
@EYHN EYHN force-pushed the jimmfly/0827/add-new-doc-edfault-mode branch from cc9365f to 09ab922 Compare August 28, 2024 02:36
Base automatically changed from jimmfly/0827/adjust-style to canary August 28, 2024 02:48
@graphite-app graphite-app bot merged commit 09ab922 into canary Aug 28, 2024
33 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0827/add-new-doc-edfault-mode branch August 28, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants