feat(core): pdf viewer supports fit to page #8812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/frontend/core/src/components/attachment-viewer/pdf-viewer.tsx
Outdated
Show resolved
Hide resolved
graphite-app
bot
requested review from
EYHN,
pengx17,
CatsJuice,
JimmFly and
forehalo
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
a72bac1 to
3c2540a
Compare
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
3c2540a to
bc9b535
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8ee0296. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #8812 +/- ##
==========================================
+ Coverage 51.91% 51.94% +0.02%
==========================================
Files 2151 2151
Lines 97440 97440
Branches 16283 16283
==========================================
+ Hits 50590 50612 +22
+ Misses 45537 45514 -23
- Partials 1313 1314 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
EYHN
reviewed
Nov 14, 2024
packages/frontend/core/src/components/attachment-viewer/pdf-viewer.tsx
Outdated
Show resolved
Hide resolved
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
bc9b535 to
e459069
Compare
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
e459069 to
3214835
Compare
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
3214835 to
e6082d0
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
43d907c to
bec5e53
Compare
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
6978e89 to
481ad7d
Compare
fundon
changed the title
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
481ad7d to
8ee0296
Compare
EYHN
approved these changes
Dec 19, 2024
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
bec5e53 to
3881b59
Compare
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
8ee0296 to
28de310
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
3881b59 to
fa41098
Compare
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
28de310 to
c8d8d86
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
fa41098 to
ecaaf4e
Compare
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
2 times, most recently
from
439e007 to
58b3e5e
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
ecaaf4e to
dc9a403
Compare
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
58b3e5e to
fcdb891
Compare
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
dc9a403 to
7b7be9b
Compare
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
fcdb891 to
bcf3ce0
Compare
Merge activity
|
### What's Changed * fits to page by default * supports rendering pages of different sizes https://github.com/user-attachments/assets/bf34e6d1-5546-4af1-a131-b801a67e9ace
fundon
force-pushed
the
fundon/11_02_pdf_embed_view
branch
from
7b7be9b to
bb43e4b
Compare
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
bcf3ce0 to
42ab507
Compare
graphite-app
bot
deleted the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Screen.Recording.2024-11-17.at.01.39.54.mov