-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(core): add tests for card view with edgeless mode link #8887
base: canary
Are you sure you want to change the base?
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8f8bd76. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #8887 +/- ##
==========================================
- Coverage 70.25% 70.16% -0.09%
==========================================
Files 550 550
Lines 33980 34005 +25
Branches 3052 3051 -1
==========================================
- Hits 23871 23861 -10
- Misses 9737 9772 +35
Partials 372 372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…#8790) Close [BS-1907](https://linear.app/affine-design/issue/BS-1907/mode=edgeless的cardview转成embed,丢失了mode信息) This PR fixed the reference information is missing during edgeless card view conversion. The test will be added to AFFiNE side toeverything/AFFiNE#8887
72d5b7b
to
8f8bd76
Compare
Close BS-1881, BS-1907, related PR toeverything/blocksuite#8785, toeverything/blocksuite#8790
This PR adds a test for the fit-to-content feature of the viewport for the embed doc block in edgeless mode.