fix(component): lit portal not re-rendering in inline links case #9321

fundon · 2024-12-26T04:15:34Z

No description provided.

fundon · 2024-12-26T04:15:50Z

refactor(core): make lit portal a bit cleaner #9354
fix(component): lit portal not re-rendering in inline links case #9321 👈 (View in Graphite)
canary

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

pengx17

please add test case

codecov · 2024-12-26T04:27:37Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.68%. Comparing base (835e7c4) to head (6fcdd01).
Report is 1 commits behind head on canary.

Files with missing lines	Patch %	Lines
.../component/src/lit-react/lit-portal/lit-portal.tsx	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           canary    #9321      +/-   ##
==========================================
+ Coverage   51.47%   51.68%   +0.20%     
==========================================
  Files        2156     2156              
  Lines       97654    97651       -3     
  Branches    16376    16416      +40     
==========================================
+ Hits        50269    50467     +198     
+ Misses      45989    45793     -196     
+ Partials     1396     1391       -5

Flag	Coverage Δ
server-test	`78.96% <ø> (+0.70%)`	⬆️
unittest	`31.01% <0.00%> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fundon · 2024-12-26T04:45:06Z

please add test case

inline links test cas:
https://github.com/toeverything/AFFiNE/blob/canary/tests/affine-local/e2e/links.spec.ts#L609
i will add pdf embed view test case in pdf PR

graphite-app · 2024-12-26T12:31:53Z

Merge activity

Dec 26, 7:31 AM EST: A user added this pull request to the Graphite merge queue.
Dec 26, 8:27 AM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (All comments must be resolved before merging).
Dec 27, 1:34 AM EST: A user added this pull request to the Graphite merge queue.
Dec 27, 2:59 AM EST: A user merged this pull request with the Graphite merge queue.

…9321) * uses `portal.key` in templates * updates `portal.id` for use in queries

packages/frontend/core/src/components/blocksuite/block-suite-editor/lit-adaper.tsx

…9321) * uses `portal.key` in templates * updates `portal.id` for use in queries

* uses `portal.key` in templates * updates `portal.id` for use in queries

github-actions bot added mod:component app:core labels Dec 26, 2024

fundon marked this pull request as ready for review December 26, 2024 04:15

graphite-app bot requested review from forehalo, pengx17, JimmFly, EYHN and CatsJuice December 26, 2024 04:15

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from 2d40aab to badcb3a Compare December 26, 2024 04:17

pengx17 reviewed Dec 26, 2024

View reviewed changes

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch 4 times, most recently from 5ffdcf8 to 14cc3a5 Compare December 26, 2024 07:46

EYHN approved these changes Dec 26, 2024

View reviewed changes

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch 2 times, most recently from 2b3f4a6 to 0ee3ba2 Compare December 26, 2024 11:59

fundon requested a review from a team as a code owner December 26, 2024 11:59

github-actions bot added the test Related to test cases label Dec 26, 2024

fundon requested a review from pengx17 December 26, 2024 11:59

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch 2 times, most recently from 1a15582 to 69f478f Compare December 26, 2024 12:22

fundon added a commit that referenced this pull request Dec 26, 2024

fix(component): fix lit portal not re-rendering in inline links case (#…

8f144e9

…9321) * uses `portal.key` in templates * updates `portal.id` for use in queries

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from 69f478f to 8f144e9 Compare December 26, 2024 12:32

pengx17 reviewed Dec 26, 2024

View reviewed changes

packages/frontend/core/src/components/blocksuite/block-suite-editor/lit-adaper.tsx Show resolved Hide resolved

fundon added a commit that referenced this pull request Dec 26, 2024

fix(component): fix lit portal not re-rendering in inline links case (#…

f046678

…9321) * uses `portal.key` in templates * updates `portal.id` for use in queries

pengx17 mentioned this pull request Dec 26, 2024

refactor(core): make lit portal a bit cleaner #9354

Merged

fundon added a commit that referenced this pull request Dec 26, 2024

fix(component): lit portal not re-rendering in inline links case (#9321)

bf5a115

* uses `portal.key` in templates * updates `portal.id` for use in queries

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from 74f954a to bf5a115 Compare December 26, 2024 13:58

fundon added a commit that referenced this pull request Dec 26, 2024

fix(component): lit portal not re-rendering in inline links case (#9321)

d92acb2

* uses `portal.key` in templates * updates `portal.id` for use in queries

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from bf5a115 to d92acb2 Compare December 26, 2024 14:01

fundon added a commit that referenced this pull request Dec 26, 2024

fix(component): lit portal not re-rendering in inline links case (#9321)

a74a077

* uses `portal.key` in templates * updates `portal.id` for use in queries

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from d92acb2 to a74a077 Compare December 26, 2024 14:09

pengx17 pushed a commit that referenced this pull request Dec 26, 2024

fix(component): lit portal not re-rendering in inline links case (#9321)

12b291c

* uses `portal.key` in templates * updates `portal.id` for use in queries

pengx17 force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from a74a077 to 12b291c Compare December 26, 2024 15:15

fundon added a commit that referenced this pull request Dec 27, 2024

fix(component): lit portal not re-rendering in inline links case (#9321)

dc491aa

* uses `portal.key` in templates * updates `portal.id` for use in queries

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from 12b291c to dc491aa Compare December 27, 2024 03:28

pengx17 pushed a commit that referenced this pull request Dec 27, 2024

fix(component): lit portal not re-rendering in inline links case (#9321)

beb61d2

* uses `portal.key` in templates * updates `portal.id` for use in queries

pengx17 force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from dc491aa to beb61d2 Compare December 27, 2024 04:29

fundon added a commit that referenced this pull request Dec 27, 2024

fix(component): lit portal not re-rendering in inline links case (#9321)

e005a1a

* uses `portal.key` in templates * updates `portal.id` for use in queries

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from beb61d2 to e005a1a Compare December 27, 2024 05:57

fundon added a commit that referenced this pull request Dec 27, 2024

fix(component): lit portal not re-rendering in inline links case (#9321)

c05ff0a

* uses `portal.key` in templates * updates `portal.id` for use in queries

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from e005a1a to c05ff0a Compare December 27, 2024 06:13

pengx17 force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from c05ff0a to beb61d2 Compare December 27, 2024 06:16

pengx17 approved these changes Dec 27, 2024

View reviewed changes

pengx17 pushed a commit that referenced this pull request Dec 27, 2024

fix(component): lit portal not re-rendering in inline links case (#9321)

8b6c427

* uses `portal.key` in templates * updates `portal.id` for use in queries

pengx17 force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from beb61d2 to 8b6c427 Compare December 27, 2024 06:37

fundon added a commit that referenced this pull request Dec 27, 2024

fix(component): lit portal not re-rendering in inline links case (#9321)

e18caac

* uses `portal.key` in templates * updates `portal.id` for use in queries

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from 8b6c427 to e18caac Compare December 27, 2024 07:09

pengx17 force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from e18caac to 8b6c427 Compare December 27, 2024 07:21

pengx17 pushed a commit that referenced this pull request Dec 27, 2024

fix(component): lit portal not re-rendering in inline links case (#9321)

9936725

* uses `portal.key` in templates * updates `portal.id` for use in queries

pengx17 force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from 8b6c427 to 9936725 Compare December 27, 2024 07:22

fix(component): lit portal not re-rendering in inline links case (#9321)

6fcdd01

* uses `portal.key` in templates * updates `portal.id` for use in queries

fundon force-pushed the fundon/12_25_fix_lit_portal_re-rendering_issue branch from 9936725 to 6fcdd01 Compare December 27, 2024 07:43

graphite-app bot merged commit 6fcdd01 into canary Dec 27, 2024
61 checks passed

graphite-app bot deleted the fundon/12_25_fix_lit_portal_re-rendering_issue branch December 27, 2024 07:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(component): lit portal not re-rendering in inline links case #9321

fix(component): lit portal not re-rendering in inline links case #9321

fundon commented Dec 26, 2024 •

edited

Loading

fundon commented Dec 26, 2024 •

edited by pengx17

Loading

pengx17 left a comment

codecov bot commented Dec 26, 2024 •

edited

Loading

fundon commented Dec 26, 2024

graphite-app bot commented Dec 26, 2024 •

edited

Loading

fix(component): lit portal not re-rendering in inline links case #9321

fix(component): lit portal not re-rendering in inline links case #9321

Conversation

fundon commented Dec 26, 2024 • edited Loading

fundon commented Dec 26, 2024 • edited by pengx17 Loading

How to use the Graphite Merge Queue

pengx17 left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 26, 2024 • edited Loading

Codecov Report

fundon commented Dec 26, 2024

graphite-app bot commented Dec 26, 2024 • edited Loading

Merge activity

fundon commented Dec 26, 2024 •

edited

Loading

fundon commented Dec 26, 2024 •

edited by pengx17

Loading

codecov bot commented Dec 26, 2024 •

edited

Loading

graphite-app bot commented Dec 26, 2024 •

edited

Loading