Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(electron): enable vscode debugger for electron #9333

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Dec 26, 2024

No description provided.

@pengx17 pengx17 marked this pull request as ready for review December 26, 2024 07:18
@graphite-app graphite-app bot requested review from CatsJuice, EYHN, forehalo and JimmFly and removed request for CatsJuice December 26, 2024 07:18
@github-actions github-actions bot added app:electron Related to electron app mod:dev labels Dec 26, 2024
Copy link
Collaborator Author

pengx17 commented Dec 26, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 requested a review from CatsJuice December 26, 2024 07:18
tools/utils/src/path.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.47%. Comparing base (188cabc) to head (7d0160c).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ore/src/modules/desktop-api/service/desktop-api.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9333      +/-   ##
==========================================
+ Coverage   51.46%   51.47%   +0.01%     
==========================================
  Files        2155     2155              
  Lines       97668    97670       +2     
  Branches    16387    16388       +1     
==========================================
+ Hits        50261    50275      +14     
- Misses      45761    46046     +285     
+ Partials     1646     1349     -297     
Flag Coverage Δ
server-test 78.24% <ø> (-0.07%) ⬇️
unittest 31.05% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/12-26-feat_electron_enable_vscode_debugger_for_electron branch 2 times, most recently from 23e41c7 to 5d7454e Compare December 26, 2024 07:32
tools/cli/src/run.ts Outdated Show resolved Hide resolved
@pengx17 pengx17 force-pushed the xp/12-26-feat_electron_enable_vscode_debugger_for_electron branch from 5d7454e to 96eb9b3 Compare December 26, 2024 07:41
@pengx17 pengx17 changed the base branch from canary to 61/patch-monorepo December 26, 2024 07:41
@pengx17 pengx17 force-pushed the xp/12-26-feat_electron_enable_vscode_debugger_for_electron branch from 96eb9b3 to 75e596a Compare December 26, 2024 07:56
@forehalo forehalo requested a review from a team as a code owner December 26, 2024 08:16
@forehalo forehalo force-pushed the 61/patch-monorepo branch 3 times, most recently from 794b781 to e5948e0 Compare December 26, 2024 10:24
@forehalo forehalo force-pushed the 61/patch-monorepo branch 6 times, most recently from 6f45187 to 4b7c5b1 Compare December 26, 2024 12:18
Base automatically changed from 61/patch-monorepo to canary December 26, 2024 12:34
@pengx17 pengx17 force-pushed the xp/12-26-feat_electron_enable_vscode_debugger_for_electron branch from 75e596a to 021a2d8 Compare December 26, 2024 15:21
Copy link

graphite-app bot commented Dec 26, 2024

Merge activity

@pengx17 pengx17 force-pushed the xp/12-26-feat_electron_enable_vscode_debugger_for_electron branch from 021a2d8 to 7d0160c Compare December 26, 2024 15:38
@graphite-app graphite-app bot merged commit 7d0160c into canary Dec 26, 2024
60 checks passed
@graphite-app graphite-app bot deleted the xp/12-26-feat_electron_enable_vscode_debugger_for_electron branch December 26, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants