Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): throttle render linked doc card when blockUpdated #9361

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Dec 27, 2024

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@donteatfriedrice donteatfriedrice marked this pull request as ready for review December 27, 2024 03:00
@donteatfriedrice donteatfriedrice requested a review from a team as a code owner December 27, 2024 03:00
@graphite-app graphite-app bot requested a review from forehalo December 27, 2024 03:00
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 51.47%. Comparing base (7dbb85c) to head (835e7c4).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...c/embed-linked-doc-block/embed-linked-doc-block.ts 37.50% 5 Missing ⚠️
...nced-doc-block/components/embed-synced-doc-card.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9361      +/-   ##
==========================================
+ Coverage   51.45%   51.47%   +0.02%     
==========================================
  Files        2156     2156              
  Lines       97653    97654       +1     
  Branches    16376    16376              
==========================================
+ Hits        50246    50269      +23     
+ Misses      46011    45989      -22     
  Partials     1396     1396              
Flag Coverage Δ
server-test 78.26% <ø> (+0.06%) ⬆️
unittest 31.06% <6.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do some improvements

@donteatfriedrice donteatfriedrice force-pushed the 12-27-fix_editor_throttle_render_linked_doc_card_when_blockupdated branch from 7e3ff15 to 429801c Compare December 27, 2024 03:29
Copy link
Contributor

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Dec 27, 2024

Merge activity

  • Dec 27, 12:40 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 27, 1:20 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Server Test').
  • Dec 27, 1:30 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 27, 2:41 AM EST: A user merged this pull request with the Graphite merge queue.

@donteatfriedrice donteatfriedrice force-pushed the 12-27-fix_editor_throttle_render_linked_doc_card_when_blockupdated branch from ce6421f to 835e7c4 Compare December 27, 2024 07:25
@graphite-app graphite-app bot merged commit 835e7c4 into canary Dec 27, 2024
61 checks passed
@graphite-app graphite-app bot deleted the 12-27-fix_editor_throttle_render_linked_doc_card_when_blockupdated branch December 27, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants