Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): cleanup ts-expect-error #9369

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review December 27, 2024 04:35
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner December 27, 2024 04:35
@graphite-app graphite-app bot requested a review from forehalo December 27, 2024 04:36
@github-actions github-actions bot added the test Related to test cases label Dec 27, 2024
Copy link
Contributor Author

Saul-Mirone commented Dec 27, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Base automatically changed from 12-27-refactor_editor_extract_edgeless_legacy_slots to canary December 27, 2024 04:39
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.49%. Comparing base (908e3ef) to head (2b27d62).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
blocksuite/affine/data-view/src/core/sort/eval.ts 0.00% 1 Missing ⚠️
...-block/widgets/element-toolbar/change-text-menu.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9369      +/-   ##
==========================================
+ Coverage   51.47%   51.49%   +0.01%     
==========================================
  Files        2156     2156              
  Lines       97649    97650       +1     
  Branches    16376    16379       +3     
==========================================
+ Hits        50266    50282      +16     
+ Misses      45987    45730     -257     
- Partials     1396     1638     +242     
Flag Coverage Δ
server-test 78.31% <ø> (+0.05%) ⬆️
unittest 31.06% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Dec 27, 2024

Merge activity

@Saul-Mirone Saul-Mirone force-pushed the 12-27-refactor_editor_cleanup_ts-expect-error branch from ee09381 to 2b27d62 Compare December 27, 2024 05:14
@graphite-app graphite-app bot merged commit 2b27d62 into canary Dec 27, 2024
61 checks passed
@graphite-app graphite-app bot deleted the 12-27-refactor_editor_cleanup_ts-expect-error branch December 27, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants