Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): move insert link command to bookmark to remove ts ignore #9370

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review December 27, 2024 05:38
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner December 27, 2024 05:38
@graphite-app graphite-app bot requested a review from forehalo December 27, 2024 05:38
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Saul-Mirone Saul-Mirone force-pushed the 12-27-fix_editor_move_insert_link_command_to_bookmark_to_remove_ts_ignore branch from 8aba0cb to c1c678a Compare December 27, 2024 05:39
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.48%. Comparing base (fee8630) to head (1fbb462).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9370      +/-   ##
==========================================
+ Coverage   51.43%   51.48%   +0.04%     
==========================================
  Files        2156     2156              
  Lines       97654    97654              
  Branches    16377    16374       -3     
==========================================
+ Hits        50233    50276      +43     
+ Misses      46031    45983      -48     
- Partials     1390     1395       +5     
Flag Coverage Δ
server-test 78.26% <ø> (+0.01%) ⬆️
unittest 31.06% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Dec 27, 2024

Merge activity

  • Dec 27, 1:02 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 27, 2:07 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Legacy Blocksuite E2E Test (3)').
  • Dec 27, 3:55 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 27, 4:25 AM EST: A user merged this pull request with the Graphite merge queue.

@Saul-Mirone Saul-Mirone force-pushed the 12-27-fix_editor_move_insert_link_command_to_bookmark_to_remove_ts_ignore branch from c1c678a to ae5e08d Compare December 27, 2024 06:51
@Saul-Mirone Saul-Mirone force-pushed the 12-27-fix_editor_move_insert_link_command_to_bookmark_to_remove_ts_ignore branch from ae5e08d to 1437434 Compare December 27, 2024 07:52
@Saul-Mirone Saul-Mirone force-pushed the 12-27-fix_editor_move_insert_link_command_to_bookmark_to_remove_ts_ignore branch from 1437434 to 1fbb462 Compare December 27, 2024 09:09
@graphite-app graphite-app bot merged commit 1fbb462 into canary Dec 27, 2024
61 checks passed
@graphite-app graphite-app bot deleted the 12-27-fix_editor_move_insert_link_command_to_bookmark_to_remove_ts_ignore branch December 27, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants