Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): end_session_endpoint is not required for oidc #9381

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

forehalo
Copy link
Member

closes #9380

Copy link
Member Author

forehalo commented Dec 27, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.42%. Comparing base (12bfbf1) to head (248141d).
Report is 3 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9381      +/-   ##
==========================================
- Coverage   51.47%   51.42%   -0.05%     
==========================================
  Files        2157     2157              
  Lines       97660    97659       -1     
  Branches    16380    16377       -3     
==========================================
- Hits        50266    50218      -48     
  Misses      46052    46052              
- Partials     1342     1389      +47     
Flag Coverage Δ
server-test 78.19% <ø> (-0.13%) ⬇️
unittest 31.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Dec 27, 2024

Merge activity

  • Dec 27, 4:59 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 27, 5:33 AM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Server Test').

@forehalo forehalo merged commit 64827f7 into canary Dec 27, 2024
60 checks passed
@forehalo forehalo deleted the 61/fix-oidc branch December 27, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

​Unable to integrate with GitLab SSO
2 participants