fix(blocks): fix slash menu is triggered in ignored blocks (#8469)

Close [BS-1501](https://linear.app/affine-design/issue/BS-1501/修正代碼區塊中-的響應問題)
toeverything · Sep 26, 2024 · cdeedd4 · cdeedd4
1 parent 5c48661
commit cdeedd4
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/packages/blocks/src/root-block/widgets/slash-menu/index.ts b/packages/blocks/src/root-block/widgets/slash-menu/index.ts
@@ -4,7 +4,10 @@ import {
   type AffineInlineEditor,
   getInlineEditorByModel,
 } from '@blocksuite/affine-components/rich-text';
-import { getCurrentNativeRange } from '@blocksuite/affine-shared/utils';
+import {
+  getCurrentNativeRange,
+  matchFlavours,
+} from '@blocksuite/affine-shared/utils';
 import { WidgetComponent } from '@blocksuite/block-std';
 import {
   assertExists,
@@ -154,6 +157,8 @@ export class AffineSlashMenuWidget extends WidgetComponent {
       const model = this.host.doc.getBlock(textSelection.blockId)?.model;
       if (!model) return;
 
+      if (matchFlavours(model, this.config.ignoreBlockTypes)) return;
+
       const inlineRange = inlineEditor.getInlineRange();
       if (!inlineRange) return;
 

diff --git a/tests/slash-menu.spec.ts b/tests/slash-menu.spec.ts
@@ -497,6 +497,19 @@ test.describe('slash menu should show and hide correctly', () => {
   });
 });
 
+test.describe('slash menu should not be shown in ignored blocks', () => {
+  test('code block', async ({ page }) => {
+    await enterPlaygroundRoom(page);
+    await initEmptyParagraphState(page);
+    await focusRichText(page);
+
+    await type(page, '```');
+    await pressEnter(page);
+    await type(page, '/');
+    await expect(page.locator('.slash-menu')).toBeHidden();
+  });
+});
+
 test('should slash menu works with fast type', async ({ page }) => {
   await enterPlaygroundRoom(page);
   await initEmptyParagraphState(page);