Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edgeless): bebas-neue light url #6395

Merged
merged 3 commits into from
Mar 13, 2024
Merged

fix(edgeless): bebas-neue light url #6395

merged 3 commits into from
Mar 13, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 5, 2024 •
edited
Loading

Screenshot 2024-03-07 at 13 36 36

@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 8:41am
blocksuite-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 8:41am

doodlewind
doodlewind approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@fundon fundon force-pushed the fix-bebas-neue-light-url branch from e32ca15 to 66b3829 Compare March 7, 2024 05:55
@fundon
Copy link
Contributor Author

fundon commented Mar 7, 2024 •
edited
Loading

@doodlewind If we want to pass the tests, we need to add BebasNeue-Light.woff font to the server.

Just only copy BebasNeue%20Light.woff to BebasNeue-Light.woff or wait for the next release.

pnpm test -- --ui

Screenshot 2024-03-07 at 14 11 17 Screenshot 2024-03-07 at 14 07 26 Screenshot 2024-03-07 at 14 07 45

@Saul-Mirone Saul-Mirone merged commit c8e7e62 into toeverything:master Mar 13, 2024
18 of 19 checks passed
@fundon fundon deleted the fix-bebas-neue-light-url branch March 13, 2024 08:42
@regischen regischen mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@fundon fundon

Labels
None yet
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fundon @doodlewind @Saul-Mirone