Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): Workspace -> DocCollection #6436

Merged
merged 11 commits into from
Mar 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import '../../database-block/kanban/define.js';
import '../../database-block/table/define.js';

import type { BlockModel, Doc } from '@blocksuite/store';
import { Generator, Schema, Workspace } from '@blocksuite/store';
import { DocCollection, Generator, Schema } from '@blocksuite/store';
import { beforeEach, describe, expect, test } from 'vitest';

import { numberPureColumnConfig } from '../../database-block/common/columns/number/define.js';
Expand All @@ -27,13 +27,13 @@ function createTestOptions() {
const idGenerator = Generator.AutoIncrement;
const schema = new Schema();
schema.register(AffineSchemas);
return { id: 'test-workspace', idGenerator, schema };
return { id: 'test-collection', idGenerator, schema };
}

function createTestDoc(docId = 'doc0') {
const options = createTestOptions();
const workspace = new Workspace(options);
const doc = workspace.createDoc({ id: docId });
const collection = new DocCollection(options);
const doc = collection.createDoc({ id: docId });
doc.load();
return doc;
}
Expand Down
12 changes: 6 additions & 6 deletions packages/blocks/src/__tests__/migration/migration.unit.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { readFile } from 'node:fs/promises';
import { join } from 'node:path';
import { fileURLToPath } from 'node:url';

import { Schema, Workspace, type Y } from '@blocksuite/store';
import { DocCollection, Schema, type Y } from '@blocksuite/store';
import { assert, describe, expect, test } from 'vitest';

import { DatabaseBlockSchema } from '../../database-block/database-model.js';
Expand All @@ -21,8 +21,8 @@ async function loadBinary(name: string) {
const path = join(originPath, `../ydocs/${name}.ydoc`);
const buffer = await readFile(path);
const update = new Uint8Array(buffer);
const doc = new Workspace.Y.Doc();
Workspace.Y.applyUpdate(doc, update);
const doc = new DocCollection.Y.Doc();
DocCollection.Y.applyUpdate(doc, update);
return doc;
}

Expand All @@ -37,16 +37,16 @@ schema.register([
FrameBlockSchema,
]);

describe('workspace migration', () => {
test('add pageVersion in workspace meta', async () => {
describe('collection migration', () => {
test('add pageVersion in collection meta', async () => {
const doc = await loadBinary('workspace-v1-v2');

const meta = doc.getMap('meta');
const before = meta.toJSON();
assert.equal(before['workspaceVersion'], 1);
assert.isUndefined(before['pageVersion']);

schema.upgradeWorkspace(doc);
schema.upgradeCollection(doc);

const after = meta.toJSON();
assert.equal(after['workspaceVersion'], 2);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { assertExists } from '@blocksuite/global/utils';
import type { EditorHost } from '@blocksuite/lit';
import { WithDisposable } from '@blocksuite/lit';
import type { BlockModel } from '@blocksuite/store';
import { Workspace } from '@blocksuite/store';
import { DocCollection } from '@blocksuite/store';
import { flip } from '@floating-ui/dom';
import { css, html, LitElement, nothing } from 'lit';
import { customElement, property, query } from 'lit/decorators.js';
Expand Down Expand Up @@ -308,7 +308,7 @@ export class EmbedCardToolbar extends WithDisposable(LitElement) {
const parent = doc.getParent(this._model);
const index = parent?.children.indexOf(this._model);

const yText = new Workspace.Y.Text();
const yText = new DocCollection.Y.Text();
const insert = this._model.title || this._model.caption || this._model.url;
yText.insert(0, insert);
yText.format(0, insert.length, { link: this._model.url });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ export const bindContainerHotkey = (blockElement: BlockElement) => {
});
inlineEditor.setInlineRange({ index: inlineRange.index - 1, length: 0 });

const doc = createDefaultDoc(blockElement.doc.workspace, {
const doc = createDefaultDoc(blockElement.doc.collection, {
title: docName,
});
insertLinkedNode({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
} from '@blocksuite/inline';
import { ShadowlessElement, WithDisposable } from '@blocksuite/lit';
import type { Y } from '@blocksuite/store';
import { Text, Workspace } from '@blocksuite/store';
import { DocCollection, Text } from '@blocksuite/store';
import { css, html } from 'lit';
import { customElement, property, query } from 'lit/decorators.js';
import { classMap } from 'lit/directives/class-map.js';
Expand Down Expand Up @@ -318,7 +318,7 @@ export class RichText extends WithDisposable(ShadowlessElement) {
assertExists(this._yText.doc, 'yText should be bind to yDoc.');

if (!this.undoManager) {
this.undoManager = new Workspace.Y.UndoManager(this._yText, {
this.undoManager = new DocCollection.Y.UndoManager(this._yText, {
trackedOrigins: new Set([this._yText.doc.clientID]),
});
}
Expand Down
4 changes: 2 additions & 2 deletions packages/blocks/src/_common/configs/quick-action/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export const quickActionConfig: QuickActionConfig[] = [
host.selection.clear();

const doc = host.doc;
const linkedDoc = doc.workspace.createDoc({});
const linkedDoc = doc.collection.createDoc({});
linkedDoc.load(() => {
const rootId = linkedDoc.addBlock('affine:page', {
title: new doc.Text(''),
Expand All @@ -158,7 +158,7 @@ export const quickActionConfig: QuickActionConfig[] = [
firstBlock.type.match(/^h[1-6]$/)
) {
const title = firstBlock.text.toString();
linkedDoc.workspace.setDocMeta(linkedDoc.id, {
linkedDoc.collection.setDocMeta(linkedDoc.id, {
title,
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export class AffineReference extends WithDisposable(ShadowlessElement) {
const doc = this.doc;
this._updateRefMeta(doc);
this._disposables.add(
doc.workspace.slots.docUpdated.on(() => this._updateRefMeta(doc))
doc.collection.slots.docUpdated.on(() => this._updateRefMeta(doc))
);

this.updateComplete
Expand All @@ -166,7 +166,7 @@ export class AffineReference extends WithDisposable(ShadowlessElement) {
const refAttribute = this.delta.attributes?.reference;
assertExists(refAttribute, 'Failed to get reference attribute!');
this._refAttribute = refAttribute;
const refMeta = doc.workspace.meta.docMetas.find(
const refMeta = doc.collection.meta.docMetas.find(
doc => doc.id === refAttribute.pageId
);
this._refMeta = refMeta
Expand Down
8 changes: 4 additions & 4 deletions packages/blocks/src/_common/mind-map/draw.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Workspace } from '@blocksuite/store';
import { DocCollection } from '@blocksuite/store';

import type { EdgelessRootService } from '../../root-block/edgeless/edgeless-root-service.js';
import { getFontString } from '../../surface-block/canvas-renderer/element-renderer/text/utils.js';
Expand Down Expand Up @@ -97,7 +97,7 @@ const drawAllNode = (
: service.addElement(CanvasElementType.SHAPE, {
...DEFAULT_SHAPE_PROPS,
xywh: `[${0},${0},${0},${0}]`,
text: new Workspace.Y.Text(text),
text: new DocCollection.Y.Text(text),
});
shapeIds.push(id);
const ele = service.getElementById(id) as ShapeElementModel;
Expand Down Expand Up @@ -229,7 +229,7 @@ export const createNode = (
const id = service.addElement(CanvasElementType.SHAPE, {
...DEFAULT_SHAPE_PROPS,
xywh: `[${0},${0},${0},${0}]`,
text: new Workspace.Y.Text(text),
text: new DocCollection.Y.Text(text),
});
const ele = service.getElementById(id) as ShapeElementModel;
const maxWidth =
Expand Down Expand Up @@ -268,7 +268,7 @@ export const changeText = (
service: EdgelessRootService
) => {
service.updateElement(id, {
text: new Workspace.Y.Text(text),
text: new DocCollection.Y.Text(text),
});
const ele = service.getElementById(id) as ShapeElementModel;
const maxWidth =
Expand Down
2 changes: 1 addition & 1 deletion packages/blocks/src/_common/transformers/html.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { HtmlAdapter } from '../adapters/index.js';
import { createAssetsArchive, download } from './utils.js';

async function exportDoc(doc: Doc) {
const job = new Job({ workspace: doc.workspace });
const job = new Job({ collection: doc.collection });
const snapshot = await job.docToSnapshot(doc);
const adapter = new HtmlAdapter();
const htmlResult = await adapter.fromDocSnapshot({
Expand Down
10 changes: 5 additions & 5 deletions packages/blocks/src/_common/transformers/markdown.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { defaultImageProxyMiddleware } from './middlewares.js';
import { createAssetsArchive, download } from './utils.js';

async function exportDoc(doc: Doc) {
const job = new Job({ workspace: doc.workspace });
const job = new Job({ collection: doc.collection });
const snapshot = await job.docToSnapshot(doc);

const adapter = new MarkdownAdapter();
Expand Down Expand Up @@ -47,17 +47,17 @@ async function importMarkdown({
noteId,
}: ImportMarkdownOptions) {
const job = new Job({
workspace: doc.workspace,
collection: doc.collection,
middlewares: [defaultImageProxyMiddleware],
});
const adapter = new MarkdownAdapter();
adapter.applyConfigs(job.adapterConfigs);
const snapshot = await adapter.toSliceSnapshot({
file: markdown,
assets: job.assetsManager,
pageVersion: doc.workspace.meta.pageVersion!,
workspaceVersion: doc.workspace.meta.workspaceVersion!,
workspaceId: doc.workspace.id,
pageVersion: doc.collection.meta.pageVersion!,
workspaceVersion: doc.collection.meta.workspaceVersion!,
workspaceId: doc.collection.id,
pageId: doc.id,
});

Expand Down
8 changes: 4 additions & 4 deletions packages/blocks/src/_common/transformers/middlewares.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type { ListBlockModel } from '../../list-block/index.js';
import type { ParagraphBlockModel } from '../../paragraph-block/index.js';
import { DEFAULT_IMAGE_PROXY_ENDPOINT } from '../consts.js';

export const replaceIdMiddleware: JobMiddleware = ({ slots, workspace }) => {
export const replaceIdMiddleware: JobMiddleware = ({ slots, collection }) => {
const idMap = new Map<string, string>();
slots.afterImport.on(payload => {
if (
Expand Down Expand Up @@ -63,7 +63,7 @@ export const replaceIdMiddleware: JobMiddleware = ({ slots, workspace }) => {
});
slots.beforeImport.on(payload => {
if (payload.type === 'page') {
const newId = workspace.idGenerator();
const newId = collection.idGenerator();
idMap.set(payload.snapshot.meta.id, newId);
payload.snapshot.meta.id = newId;
return;
Expand All @@ -86,7 +86,7 @@ export const replaceIdMiddleware: JobMiddleware = ({ slots, workspace }) => {
if (idMap.has(original)) {
newId = idMap.get(original)!;
} else {
newId = workspace.idGenerator();
newId = collection.idGenerator();
idMap.set(original, newId);
}
snapshot.id = newId;
Expand All @@ -98,7 +98,7 @@ export const replaceIdMiddleware: JobMiddleware = ({ slots, workspace }) => {
if (idMap.has(original)) {
newId = idMap.get(original)!;
} else {
newId = workspace.idGenerator();
newId = collection.idGenerator();
idMap.set(original, newId);
}
});
Expand Down
26 changes: 13 additions & 13 deletions packages/blocks/src/_common/transformers/zip.ts
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
import { assertExists } from '@blocksuite/global/utils';
import type {
CollectionInfoSnapshot,
Doc,
DocCollection,
DocSnapshot,
JobMiddleware,
Workspace,
WorkspaceInfoSnapshot,
} from '@blocksuite/store';
import { getAssetName, Job, sha } from '@blocksuite/store';
import JSZip from 'jszip';

import { replaceIdMiddleware } from './middlewares.js';

async function exportDocs(workspace: Workspace, docs: Doc[]) {
async function exportDocs(collection: DocCollection, docs: Doc[]) {
const zip = new JSZip();

const job = new Job({ workspace });
const job = new Job({ collection });
const snapshots = await Promise.all(docs.map(job.docToSnapshot));

const workspaceInfo = job.workspaceInfoToSnapshot();
zip.file('info.json', JSON.stringify(workspaceInfo, null, 2));
const collectionInfo = job.collectionInfoToSnapshot();
zip.file('info.json', JSON.stringify(collectionInfo, null, 2));

snapshots.forEach(snapshot => {
const snapshotName = `${snapshot.meta.id}.snapshot.json`;
Expand All @@ -38,14 +38,14 @@ async function exportDocs(workspace: Workspace, docs: Doc[]) {
return zip.generateAsync({ type: 'blob' });
}

async function importDocs(workspace: Workspace, imported: Blob) {
async function importDocs(collection: DocCollection, imported: Blob) {
const zip = new JSZip();
const { files } = await zip.loadAsync(imported);

const assetObjs: JSZip.JSZipObject[] = [];
const snapshotsObjs: JSZip.JSZipObject[] = [];
let infoObj: JSZip.JSZipObject | undefined;
let info: WorkspaceInfoSnapshot | undefined;
let info: CollectionInfoSnapshot | undefined;

Object.entries(files).map(([name, fileObj]) => {
if (name.includes('MACOSX') || name.includes('DS_Store')) {
Expand All @@ -71,13 +71,13 @@ async function importDocs(workspace: Workspace, imported: Blob) {
{
const json = await infoObj?.async('text');
assertExists(json);
info = JSON.parse(json) as WorkspaceInfoSnapshot;
info = JSON.parse(json) as CollectionInfoSnapshot;
}

const migrationMiddleware: JobMiddleware = ({ slots, workspace }) => {
const migrationMiddleware: JobMiddleware = ({ slots, collection }) => {
slots.afterImport.on(payload => {
if (payload.type === 'page') {
workspace.schema.upgradeDoc(
collection.schema.upgradeDoc(
info?.pageVersion ?? 0,
{},
payload.page.spaceDoc
Expand All @@ -86,12 +86,12 @@ async function importDocs(workspace: Workspace, imported: Blob) {
});
};
const job = new Job({
workspace,
collection,
middlewares: [replaceIdMiddleware, migrationMiddleware],
});
const assetsMap = job.assets;

job.snapshotToWorkspaceInfo(info);
job.snapshotToCollectionInfo(info);

await Promise.all(
assetObjs.map(async fileObj => {
Expand Down
8 changes: 4 additions & 4 deletions packages/blocks/src/_common/utils/init.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
import type { Workspace } from '@blocksuite/store';
import type { DocCollection } from '@blocksuite/store';

export function createDefaultDoc(
workspace: Workspace,
collection: DocCollection,
options: { id?: string; title?: string } = {}
) {
const doc = workspace.createDoc({ id: options.id });
const doc = collection.createDoc({ id: options.id });

doc.load();
const title = options.title ?? '';
const rootId = doc.addBlock('affine:page', {
title: new doc.Text(title),
});
workspace.setDocMeta(doc.id, {
collection.setDocMeta(doc.id, {
title,
});
doc.addBlock('affine:surface', {}, rootId);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { assertExists } from '@blocksuite/global/utils';
import type { Y } from '@blocksuite/store';
import { Text, Workspace } from '@blocksuite/store';
import { DocCollection, Text } from '@blocksuite/store';
import { css, nothing } from 'lit';
import { customElement, query } from 'lit/decorators.js';
import { html } from 'lit/static-html.js';
Expand Down Expand Up @@ -142,7 +142,7 @@ export class RichTextCell extends BaseCellRenderer<Y.Text> {
}

private _initYText = (text?: string) => {
const yText = new Workspace.Y.Text(text);
const yText = new DocCollection.Y.Text(text);
this.onChange(yText);
};

Expand Down
Loading
Loading