Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve ThemeObserver and add tests #7727

Merged
merged 1 commit into from
Sep 23, 2024
Merged

chore: improve ThemeObserver and add tests #7727

merged 1 commit into from
Sep 23, 2024

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Jul 25, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jul 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 7:38am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 7:38am

@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 25, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

This was referenced Jul 25, 2024
Merged
Merged
@fundon Graphite App
Copy link
Contributor Author

fundon commented Jul 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from be1b797 to 89df18f Compare July 25, 2024 08:15
@fundon fundon temporarily deployed to Lightweight Test July 25, 2024 08:19 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Lightweight Test July 25, 2024 08:19 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Integration Test July 25, 2024 08:21 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Integration Test July 25, 2024 08:21 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Playground E2E Test July 25, 2024 08:22 — with GitHub Actions Inactive
@fundon fundon force-pushed the 07_24-add-tests-for-color-picker branch from 800fd6f to 4dfbd25 Compare July 25, 2024 09:16
@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from 89df18f to cffa8b7 Compare July 25, 2024 09:16
@fundon fundon temporarily deployed to Lightweight Test July 25, 2024 09:20 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Lightweight Test July 25, 2024 09:20 — with GitHub Actions Inactive
@fundon fundon temporarily deployed to Integration Test July 25, 2024 09:22 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 15, 2024 •
edited
Loading

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.03 MB (-0.04% 🔽)
@blocksuite/affine/block-std 144.92 KB (0%)
@blocksuite/affine/block-std/gfx 75.93 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.82 KB (0%)
@blocksuite/affine/global/env 231 B (0%)
@blocksuite/affine/global/exceptions 552 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 69.09 KB (0%)
@blocksuite/affine/inline 30.45 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.83 MB (+0.03% 🔺)
@blocksuite/affine/blocks 1.92 MB (+0.04% 🔺)
@blocksuite/affine/blocks/schemas 85.48 KB (0%)

doodlewind
doodlewind requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@doodlewind doodlewind left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scenario (calling editor APIs) should fit better in the integration tests in the presets packages, which could also run much faster.

@fundon
Copy link
Contributor Author

fundon commented Sep 19, 2024

This scenario (calling editor APIs) should fit better in the integration tests in the presets packages, which could also run much faster.

I will refactor it this week.

@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from 7124229 to 932a522 Compare September 22, 2024 07:14
@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from 932a522 to c031eba Compare September 22, 2024 08:47
@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from c031eba to 4d12fa1 Compare September 22, 2024 11:40
@fundon fundon changed the title chore: add color picker tests for shapes refactor(theme): improve ThemeObserver and add tests Sep 22, 2024
@fundon fundon changed the title refactor(theme): improve ThemeObserver and add tests refactor(blocks): improve ThemeObserver and add tests Sep 22, 2024
@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from 4d12fa1 to 448fb2b Compare September 22, 2024 13:09
@fundon fundon force-pushed the 07_25_add_color_picker_tests_for_shapes branch from 448fb2b to dcc8447 Compare September 22, 2024 13:21
@fundon fundon marked this pull request as ready for review September 22, 2024 13:24
@fundon fundon requested a review from a team as a code owner September 22, 2024 13:24
@fundon fundon changed the title refactor(blocks): improve ThemeObserver and add tests chore: improve ThemeObserver and add tests Sep 23, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 23, 2024 •
edited
Loading

Merge activity

  • Sep 23, 3:36 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 23, 3:36 AM EDT: doodlewind added this pull request to the Graphite merge queue.
  • Sep 23, 3:42 AM EDT: doodlewind merged this pull request with the Graphite merge queue.

@doodlewind doodlewind force-pushed the 07_25_add_color_picker_tests_for_shapes branch from dcc8447 to 417b72c Compare September 23, 2024 07:37
@graphite-app graphite-app bot merged commit 417b72c into master Sep 23, 2024
36 checks passed
@graphite-app graphite-app bot deleted the 07_25_add_color_picker_tests_for_shapes branch September 23, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doodlewind doodlewind doodlewind approved these changes

Assignees

@fundon fundon

Labels
merge
Projects
BlockSuite Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fundon @doodlewind