feat(blocks): add scroll anchoring widget #8378

fundon · 2024-09-17T05:23:13Z

add highlight type selection
impl scroll anchoring widget

🎥 Video uploaded on Graphite:

vercel · 2024-09-17T05:23:16Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
blocksuite	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 18, 2024 7:29am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
blocksuite-docs	⬜️ Ignored (Inspect)	Visit Preview		Sep 18, 2024 7:29am

changeset-bot · 2024-09-17T05:23:17Z

⚠️ No Changeset found

Latest commit: 290c9ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-09-17T05:23:20Z

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

fundon · 2024-09-17T05:23:26Z

feat(blocks): add scroll anchoring widget #8378 👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite

nx-cloud · 2024-09-17T05:24:24Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 290c9ed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx vite:build @blocksuite/playground

Sent with 💌 from NxCloud.

github-actions · 2024-09-17T05:25:45Z

size-limit report 📦

Path	Size
@blocksuite/affine-block-embed	119 KB (0%)
@blocksuite/affine-block-list	5.94 KB (0%)
@blocksuite/affine-block-paragraph	4.5 KB (0%)
@blocksuite/affine-block-surface	82.1 KB (0%)
@blocksuite/affine-components	366.88 KB (0%)
@blocksuite/data-view	205.57 KB (-2.11% 🔽)
@blocksuite/affine-model	30.02 KB (0%)
@blocksuite/affine-shared	26.03 KB (+1.61% 🔺)
@blocksuite/blocks	2.64 MB (-0.05% 🔽)
@blocksuite/block-std	106.48 KB (+0.66% 🔺)
@blocksuite/global	28.41 KB (0%)
@blocksuite/inline	23.76 KB (0%)
@blocksuite/store	64 KB (0%)
@blocksuite/sync	95.99 KB (0%)
@blocksuite/presets	200.68 KB (0%)
@blocksuite/affine-widget-scroll-anchoring	-16 B (+100% 🔺)

packages/framework/block-std/src/selection/variants/hightlight.ts

packages/blocks/src/root-block/widgets/scroll-anchoring/index.ts

Saul-Mirone · 2024-09-18T02:20:46Z

You should also fix the size limit report.

packages/affine/widget-scroll-anchoring/src/scroll-anchoring.ts

packages/affine/widget-scroll-anchoring/tsconfig.json

fundon · 2024-09-18T03:50:40Z

How to fix it?

.github/snapshot-changeset.md

graphite-app · 2024-09-18T07:27:14Z

Merge activity

Sep 18, 3:27 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 18, 3:27 AM EDT: Saul-Mirone added this pull request to the Graphite merge queue.
Sep 18, 3:32 AM EDT: Saul-Mirone merged this pull request with the Graphite merge queue.

Closes [BS-1318](https://linear.app/affine-design/issue/BS-1318/在-selection-中添加-highlight-type) * add highlight type selection * impl scroll anchoring widget <div class='graphite__hidden'> <div>🎥 Video uploaded on Graphite:</div> <a href="https://app.graphite.dev/media/video/8ypiIKZXudF5a0tIgIzf/ca7b10f9-a847-456a-9088-7151feeb0e35.mov"> <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/8ypiIKZXudF5a0tIgIzf/ca7b10f9-a847-456a-9088-7151feeb0e35.mov"> </a> </div> <video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/8ypiIKZXudF5a0tIgIzf/ca7b10f9-a847-456a-9088-7151feeb0e35.mov">Screen Recording 2024-09-17 at 13.25.33.mov</video>

Upstreams: toeverything/blocksuite#8378

github-actions bot assigned fundon Sep 17, 2024

vercel bot deployed to Preview – blocksuite September 17, 2024 05:24 View deployment

fundon marked this pull request as ready for review September 17, 2024 05:28

fundon requested a review from a team as a code owner September 17, 2024 05:28

fundon mentioned this pull request Sep 17, 2024

refactor(core): improve scroll anchoring logic toeverything/AFFiNE#8269

Merged

Saul-Mirone reviewed Sep 17, 2024

View reviewed changes

packages/framework/block-std/src/selection/variants/hightlight.ts Outdated Show resolved Hide resolved

Saul-Mirone requested changes Sep 17, 2024

View reviewed changes

fundon force-pushed the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch from 1ec49cc to cc6b665 Compare September 18, 2024 00:13

vercel bot deployed to Preview – blocksuite September 18, 2024 00:14 View deployment

fundon force-pushed the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch from cc6b665 to bb309d9 Compare September 18, 2024 00:17

vercel bot deployed to Preview – blocksuite September 18, 2024 00:18 View deployment

fundon force-pushed the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch from bb309d9 to b2bbaf7 Compare September 18, 2024 01:00

vercel bot deployed to Preview – blocksuite September 18, 2024 01:01 View deployment

fundon requested a review from Saul-Mirone September 18, 2024 01:10

Saul-Mirone reviewed Sep 18, 2024

View reviewed changes

packages/affine/widget-scroll-anchoring/src/scroll-anchoring.ts Outdated Show resolved Hide resolved

Saul-Mirone reviewed Sep 18, 2024

View reviewed changes

packages/affine/widget-scroll-anchoring/tsconfig.json Show resolved Hide resolved

fundon force-pushed the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch from b2bbaf7 to b5b9faf Compare September 18, 2024 02:44

vercel bot deployed to Preview – blocksuite September 18, 2024 02:46 View deployment

fundon force-pushed the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch from b5b9faf to c8a1336 Compare September 18, 2024 02:47

vercel bot deployed to Preview – blocksuite September 18, 2024 02:48 View deployment

fundon force-pushed the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch 2 times, most recently from 694747b to f303a76 Compare September 18, 2024 03:43

vercel bot deployed to Preview – blocksuite September 18, 2024 03:45 View deployment

fundon changed the title ~~feat(blocks): impl scroll anchoring widget and highlight selection~~ feat(blocks): add scroll anchoring widget Sep 18, 2024

fundon force-pushed the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch from f303a76 to 44b6c51 Compare September 18, 2024 05:40

vercel bot deployed to Preview – blocksuite September 18, 2024 05:41 View deployment

fundon force-pushed the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch from 44b6c51 to 5e81f80 Compare September 18, 2024 05:53

vercel bot deployed to Preview – blocksuite September 18, 2024 05:54 View deployment

fundon force-pushed the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch from 5e81f80 to 1ec6909 Compare September 18, 2024 06:01

vercel bot deployed to Preview – blocksuite September 18, 2024 06:02 View deployment

Saul-Mirone approved these changes Sep 18, 2024

View reviewed changes

Saul-Mirone reviewed Sep 18, 2024

View reviewed changes

.github/snapshot-changeset.md Show resolved Hide resolved

fundon force-pushed the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch from 1ec6909 to 655934a Compare September 18, 2024 07:06

vercel bot deployed to Preview – blocksuite September 18, 2024 07:07 View deployment

fundon force-pushed the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch from 655934a to 5932669 Compare September 18, 2024 07:14

vercel bot deployed to Preview – blocksuite September 18, 2024 07:15 View deployment

Saul-Mirone added the merge label Sep 18, 2024

Saul-Mirone force-pushed the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch from 5932669 to 290c9ed Compare September 18, 2024 07:28

vercel bot deployed to Preview – blocksuite September 18, 2024 07:29 View deployment

graphite-app bot merged commit 290c9ed into master Sep 18, 2024
35 of 36 checks passed

graphite-app bot deleted the fundon/09_17_feat_impl_scroll-anchoring_and_highlight_selection branch September 18, 2024 07:32

vercel bot deployed to Production – blocksuite September 18, 2024 07:33 View deployment

fundon added a commit to toeverything/AFFiNE that referenced this pull request Sep 19, 2024

refactor(core): improve scroll anchoring logic (#8269)

6921c30

Upstreams: toeverything/blocksuite#8378

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(blocks): add scroll anchoring widget #8378

feat(blocks): add scroll anchoring widget #8378

fundon commented Sep 17, 2024 •

edited

Loading

vercel bot commented Sep 17, 2024 •

edited

Loading

changeset-bot bot commented Sep 17, 2024 •

edited

Loading

graphite-app bot commented Sep 17, 2024

fundon commented Sep 17, 2024

nx-cloud bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

Saul-Mirone commented Sep 18, 2024

fundon commented Sep 18, 2024

graphite-app bot commented Sep 18, 2024 •

edited

Loading

feat(blocks): add scroll anchoring widget #8378

feat(blocks): add scroll anchoring widget #8378

Conversation

fundon commented Sep 17, 2024 • edited Loading

vercel bot commented Sep 17, 2024 • edited Loading

changeset-bot bot commented Sep 17, 2024 • edited Loading

⚠️ No Changeset found

graphite-app bot commented Sep 17, 2024

Your org has enabled the Graphite merge queue for merging into master

fundon commented Sep 17, 2024

nx-cloud bot commented Sep 17, 2024 • edited Loading

☁️ Nx Cloud Report

github-actions bot commented Sep 17, 2024 • edited Loading

size-limit report 📦

Saul-Mirone commented Sep 18, 2024

fundon commented Sep 18, 2024

graphite-app bot commented Sep 18, 2024 • edited Loading

Merge activity

fundon commented Sep 17, 2024 •

edited

Loading

vercel bot commented Sep 17, 2024 •

edited

Loading

changeset-bot bot commented Sep 17, 2024 •

edited

Loading

nx-cloud bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

graphite-app bot commented Sep 18, 2024 •

edited

Loading