Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better scroll to target #8423

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Sep 21, 2024

I think this will prevent the scroll event from being interrupted.

When you click affine-reference, the refereshKey parameter on the link will be updated.

href="/workspace/gQux6wXgQWP-KkIC6uUDE/cvygdlykaIR5my9Hp_9nB?mode=page&blockIds=dx2sB9LE_eudTUbWAZ_N6&refreshKey=1-wP1OTe9AajEv6Rdm9X3"

Before

Screen.Recording.2024-09-22.at.14.46.37.mov

After

Screen.Recording.2024-09-22.at.14.53.43.mov

Copy link

vercel bot commented Sep 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 10:59am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 10:59am

Copy link

changeset-bot bot commented Sep 21, 2024

⚠️ No Changeset found

Latest commit: ddfc5d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Sep 21, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@fundon fundon marked this pull request as ready for review September 21, 2024 08:20
@fundon fundon requested a review from a team as a code owner September 21, 2024 08:20
Copy link
Contributor Author

fundon commented Sep 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fundon and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ddfc5d2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Sep 21, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.03 MB (+0.03% 🔺)
@blocksuite/affine/block-std 144.92 KB (0%)
@blocksuite/affine/block-std/gfx 75.93 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.82 KB (0%)
@blocksuite/affine/global/env 231 B (0%)
@blocksuite/affine/global/exceptions 552 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 69.09 KB (0%)
@blocksuite/affine/inline 30.45 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.83 MB (+0.02% 🔺)
@blocksuite/affine/blocks 1.92 MB (+0.01% 🔺)
@blocksuite/affine/blocks/schemas 85.48 KB (0%)

@fundon fundon added dont merge Experimental pull requests and removed dont merge Experimental pull requests labels Sep 22, 2024
@fundon fundon force-pushed the fundon/09_21_fix_scroll_into_view branch from d292a7b to cf38379 Compare September 22, 2024 07:07
@fundon fundon added the merge label Sep 23, 2024
Copy link

graphite-app bot commented Sep 23, 2024

Merge activity

  • Sep 23, 6:57 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 23, 6:57 AM EDT: fundon added this pull request to the Graphite merge queue.
  • Sep 23, 7:02 AM EDT: fundon merged this pull request with the Graphite merge queue.

I think this will prevent the scroll event from being interrupted.

When you click affine-reference, the `refereshKey` parameter on the link will be updated.

`href="/workspace/gQux6wXgQWP-KkIC6uUDE/cvygdlykaIR5my9Hp_9nB?mode=page&blockIds=dx2sB9LE_eudTUbWAZ_N6&refreshKey=1-wP1OTe9AajEv6Rdm9X3"`

### Before

https://github.com/user-attachments/assets/8c91118a-1704-419b-ac2a-008ed7e624d7

### After

https://github.com/user-attachments/assets/b7a37e1e-db03-4207-90c4-1e743fee2c7a
@fundon fundon force-pushed the fundon/09_21_fix_scroll_into_view branch from cf38379 to ddfc5d2 Compare September 23, 2024 10:57
@graphite-app graphite-app bot merged commit ddfc5d2 into master Sep 23, 2024
36 checks passed
@graphite-app graphite-app bot deleted the fundon/09_21_fix_scroll_into_view branch September 23, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants