Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to disable signature check #206

Closed
mm-chia opened this issue Jul 15, 2024 · 3 comments · Fixed by #208
Closed

Add flag to disable signature check #206

mm-chia opened this issue Jul 15, 2024 · 3 comments · Fixed by #208
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@mm-chia
Copy link

mm-chia commented Jul 15, 2024

Currently, installing Tofu v1.8.0-beta2 fails because of signature issues (I assume they only do this for regular releases, not on pre-release versions?).

It would be nice if tenv had a flag to disable signature checks, for cases like these, because I am forced to install this tofu version manually :(

thanks!

Installing OpenTofu 1.8.0-beta2
Fetching release information from https://api.github.com/repos/opentofu/opentofu/releases/tags/v1.8.0-beta2
Downloading https://github.com/opentofu/opentofu/releases/download/v1.8.0-beta2/tofu_1.8.0-beta2_darwin_arm64.zip
Downloading https://github.com/opentofu/opentofu/releases/download/v1.8.0-beta2/tofu_1.8.0-beta2_SHA256SUMS
Downloading https://github.com/opentofu/opentofu/releases/download/v1.8.0-beta2/tofu_1.8.0-beta2_SHA256SUMS.sig
Downloading https://github.com/opentofu/opentofu/releases/download/v1.8.0-beta2/tofu_1.8.0-beta2_SHA256SUMS.pem
Error: cosign check failed
Usage:
  tenv tofu install [version] [flags]
...

A possible workaround is to remove cosign package before running this command and re-installing it afterwards.
But it's ugly :)

@kvendingoldo
Copy link
Collaborator

Agree, that it's a good idea to skip verification check for such cases

@kvendingoldo kvendingoldo added the enhancement New feature or request label Jul 15, 2024
@dvaumoron dvaumoron self-assigned this Jul 15, 2024
@dvaumoron
Copy link
Contributor

dvaumoron commented Jul 15, 2024

It seem they have changed the identity used with cosign for non stable release, found in their doc :

# For alpha and beta builds use /main

TODOs for tenv :

  • fix the corner case to check alpha and beta signature correctly
  • add a flag to skip signature to prevent blocking our users on such drift

dvaumoron added a commit that referenced this issue Jul 15, 2024
Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com>
dvaumoron added a commit that referenced this issue Jul 15, 2024
Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com>
@dvaumoron dvaumoron added the bug Something isn't working label Jul 15, 2024
dvaumoron added a commit that referenced this issue Jul 15, 2024
Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com>
dvaumoron added a commit that referenced this issue Jul 15, 2024
Signed-off-by: Denis Vaumoron <dvaumoron@gmail.com>
@mm-chia
Copy link
Author

mm-chia commented Jul 16, 2024

Great job, I tested using tenv 2.6.0 and the skip signature flag works as expected.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants