Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md For Windows Install #147

Merged
merged 3 commits into from
May 28, 2024

Conversation

ImIOImI
Copy link
Contributor

@ImIOImI ImIOImI commented May 28, 2024

Choco's latest version for cosign is 1.3.1. This isn't compatible with the current tenv build. Windows users should use go to install cosign instead

Choco's latest version for cosign is 1.3.1. This isn't compatible with the current tenv build. Windows users should use go to install cosign instead

Signed-off-by: Troy Knapp <troy.knapp@sumersports.com>
@kvendingoldo
Copy link
Collaborator

kvendingoldo commented May 28, 2024

Pls, replace also choco install cosign, as well as brew install cosign

Signed-off-by: Troy Knapp <troy.knapp@sumersports.com>
@kvendingoldo
Copy link
Collaborator

kvendingoldo commented May 28, 2024

I think that we also should fix sentence

If you need to enable cosign checks, install cosign tool via one of the following commands

->

If you need to enable cosign checks, install cosign (v.2.0+) tool via one of the following commands

Signed-off-by: Troy Knapp <troy.knapp@sumersports.com>
@ImIOImI
Copy link
Contributor Author

ImIOImI commented May 28, 2024

Updated based on the previous comments. Thanks!

Copy link
Collaborator

@kvendingoldo kvendingoldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kvendingoldo kvendingoldo merged commit 9f367a5 into tofuutils:main May 28, 2024
1 check passed
@kvendingoldo kvendingoldo mentioned this pull request Jun 2, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants