Add EditorConfig #69
Closed
Add EditorConfig #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary periods.
Bumps [github.com/ProtonMail/gopenpgp/v2](https://github.com/ProtonMail/gopenpgp) from 2.7.4 to 2.7.5. - [Release notes](https://github.com/ProtonMail/gopenpgp/releases) - [Changelog](https://github.com/ProtonMail/gopenpgp/blob/main/CHANGELOG.md) - [Commits](ProtonMail/gopenpgp@v2.7.4...v2.7.5) --- updated-dependencies: - dependency-name: github.com/ProtonMail/gopenpgp/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3...v4) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…ons/golangci/golangci-lint-action-4 ci: bump golangci/golangci-lint-action from 3 to 4
feat: add Chocolatey package
Add docker container build and push workflow
…github.com/ProtonMail/gopenpgp/v2-2.7.5 ci: bump github.com/ProtonMail/gopenpgp/v2 from 2.7.4 to 2.7.5
Signed-off-by: Edwin Kofler <edwin@kofler.dev>
|
Go has its own formatting rules, so maybe *.go file should be excluded |
|
agree about go |
|
Are there any specific rules that you would like to be excluded? As long as the default Go formatting rules don't contradict the EditorConfig, then contributors will still automatically get the correct file editing settings. If Go is excluded as a whole, then settings may be incorrect when typing in a Go file, and only fixed if |
|
That's not my point, an editor supporting Go should already enforce Go formatting rules with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As alluded to in this PR, this adds an EditorConfig. It's similar to that in the original PR, except the default indent_style was changed to tab, since the majority of the code is written in Go. The rest of the file is written as a result.
FYI: The link in
.github/CONTRIBUTING.mdis broken