-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auto-tracker): Add auto tracking capability to extension #2302
Conversation
fa6bcca
to
6d8945a
Compare
d6b3726
to
bd895a2
Compare
I dont have heap access @izontm Please share top 10 integration list so we can validate for them |
@with-shrey for the last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing i wanted to be sure about.
Rest is LGTM.
{ observe: true }, | ||
function (elem) { | ||
if (!elem) return; | ||
setTimeout(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the setTimeout here? Does the debounceInterval set to 2000 does not work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesnt do it for the first render
5fb6ca1
to
7055387
Compare
Please remember the Contributing Guidelines ❤️
🌟 What does this PR do?
🐛 Recommendations for testing
All changes should be tested across Chrome and Firefox.
📝 Links to relevant issues or information