fix(calendar): Fix calendar detail view and hide button from create view #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please remember the Contributing Guidelines ❤️
🌟 What does this PR do?
Problems:
The button was placed incorrectly on create event view
And was missing from detailed view (full screen editing)
Solution
By the look at integration code
Button was not supposed to work on detailed creation screen
So i hid it from dialog creation as well since it cant pull a description to make it work
Additionally, Fixed the selector for detailed view editing
🐛 Recommendations for testing
To go to detailed view
Edit an existing event or
Click on mor options while creating the event
All changes should be tested across Chrome and Firefox.
📝 Links to relevant issues or information
https://toggl.slack.com/archives/C043ZPZQ2JC/p1733747837368349