add option to make use of yo61/logrotate module optional

[monotek]

yo61/logrotate is not compatible to Ubuntu 16.04 and messes up logrotate in a way where it does not run anymore.

Errors are like:
error: skipping "/var/log/apport.log" because parent directory has insecure permissions (It's world writable or writable by group which is not "root") Set "su" directive in config file to tell logrotate which user/group should be used for rotation.

Added option to params to not use this module and add the logrotate duply file to logrotate.d dir via a file resource instead.

[tohuwabohu]

I would suggest to remove the yo61 part from $duply_use_yo61_log_module so it is less implementation specific. Other than it looks good to me. Can you please check the Travis build?

[monotek]

Renamed $duply_use_yo61_log_module to $duply_use_logrotate_module and fixed travis.

[monotek]

What do you think about the default setting?
I think disabling the module by default is better as long as it can destroy your logrotate setup.
Currently its still used by default.

[tohuwabohu]

What do you think about the default setting?
I think disabling the module by default is better as long as it can destroy your logrotate setup.
Currently its still used by default.

Yeah, I agree to make this the new default for Ubuntu 16.04.

Also can you please quickly check if voxpupuli/puppet-logrotate#43 fixes the problem for you? In that case we know at least it is already fixed and would 'only' need to wait for a new release (or alternatively offer people to checkout the module from github).

[monotek]

Yes, it seems to fix the problem.
I would prefer not to use this module anyway.
Imho people also do not expect that logrotate is managed differently when they install a backup module.

[tohuwabohu]

The change is part of version 4.5.0 which I've just released to the forge, thanks for your contribution.