added support for FreeBSD #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # to start the service because it is still running. This script checks the status and issues the start command as | ||
| # soon as the service is actually stopped. | ||
| if $openntp::service_restart != undef { | ||
| if $openntp::service_restart == $openntp::params::service_restart { |
There was a problem hiding this comment.
Would it make sense to merge both if conditions into one if block?
There was a problem hiding this comment.
I separated the two if blocks for other variants of openntp::service_restart to come, but the two blocks can certainly be merged.
There was a problem hiding this comment.
hmm k. Looks like YAGNI to me but I'm happy to roll with it for the moment.
|
I've released 2.3.0 to the forge. Thanks for your contribution. |
|
Thanks or merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Ubuntu 15.10 and FreeBSD 10.
I'm planning to stick with this module and provide updates for FreeBSD if needed. :-)
Thanks for sharing!