Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0]: Rename variables non-functional #2645

Closed
six7 opened this issue Apr 14, 2024 · 1 comment · Fixed by #2670
Closed

[2.0]: Rename variables non-functional #2645

six7 opened this issue Apr 14, 2024 · 1 comment · Fixed by #2670
Assignees
@six7
Labels
bug Something isn't working ❇️ Featurebase Roadmap Issue was added to a featurebase roadmap post Figma export Previously create and sync styles variables Figma variables plugin v2 variables, UI, WTCG format, Bitbucket token name

Comments

@six7
Copy link
Collaborator

six7 commented Apr 14, 2024

Trying to rename a token and checking the Rename variable option, does not lead to us renaming that variable

To reproduce:

  • Create a token and create variables
  • Rename that token in the plugin
  • Notice how nothing happens
@six7 six7 added bug Something isn't working plugin v2 variables, UI, WTCG format, Bitbucket labels Apr 14, 2024
@six7 six7 moved this to 📤 Ready for dev in Tokens Studio for Figma Roadmap Apr 14, 2024
@six7 six7 changed the title 2.0: Rename variables non-functional [2.0]: Rename variables non-functional Apr 14, 2024
@SamIam4Hyma SamIam4Hyma added Figma variables Figma export Previously create and sync styles variables token name ❇️ Featurebase Roadmap Issue was added to a featurebase roadmap post labels Apr 15, 2024
@SamIam4Hyma
Copy link
Collaborator

Added to Featurebase Roadmap- ❖ 🪄 Sync variables and styles is now Export to Figma

@robinhoodie0823 robinhoodie0823 self-assigned this Apr 18, 2024
@robinhoodie0823 robinhoodie0823 moved this from 📤 Ready for dev to 🕜 In Progress in Tokens Studio for Figma Roadmap Apr 18, 2024
@robinhoodie0823 robinhoodie0823 moved this from 🕜 In Progress to 📤 Ready for dev in Tokens Studio for Figma Roadmap Apr 18, 2024
@robinhoodie0823 robinhoodie0823 removed their assignment Apr 18, 2024
@LukeFinch LukeFinch self-assigned this Apr 18, 2024
@LukeFinch LukeFinch mentioned this issue Apr 18, 2024
Closed
@robinhoodie0823 robinhoodie0823 moved this from 📤 Ready for dev to 🕜 In Progress in Tokens Studio for Figma Roadmap Apr 18, 2024
@robinhoodie0823 robinhoodie0823 mentioned this issue Apr 19, 2024
Merged
@robinhoodie0823 robinhoodie0823 moved this from 🕜 In Progress to 👀 Needs review in Tokens Studio for Figma Roadmap Apr 19, 2024
@six7 six7 moved this from 👀 Needs review to 📋 Changes requested in Tokens Studio for Figma Roadmap Apr 24, 2024
@six7 six7 mentioned this issue Apr 28, 2024
Merged
@six7 six7 assigned six7 and unassigned robinhoodie0823 Apr 28, 2024
@six7 six7 moved this from 📋 Changes requested to 🕜 In Progress in Tokens Studio for Figma Roadmap Apr 28, 2024
six7 added a commit that referenced this issue Apr 30, 2024
@six7
2.0: refactor rename variables styles (#2700)
3c88d4e 
### Why does this PR exist?

Closes #2645

(refactors the other PR)

### What does this pull request do?

- introduce settings let users choose to rename / remove styles and
variables
- introduce logic to perform rename of variables and styles
- introduce logic to perform remove of variables and styles
six7 added a commit that referenced this issue Apr 30, 2024
@robinhoodie0823 @LukeFinch @six7
2645 20 rename variables non functional 1 (#2670)
03d3477 
<!--
  Notes for authors:
  - Provide context with minimal words, keep it concise
  - Mark as a draft for work in progress PRs
  - Once ready for review, notify others in #code-reviews
- Remember, the review process is a learning opportunity for both
reviewers and authors, it's a way for us to share knowledge and avoid
silos.
-->

### Why does this PR exist?
Current plugin does not update existing variables and styles and does
not remove variables and styles without connection.

Closes #2645 <!-- link the related issue -->

<!--
Describe the problem you're addressing and the rationale behind this PR.
-->

### What does this pull request do?
Added sync functions to sync with all updates.

<!--
Detailed summary of the changes, including any visual or interactive
updates.
For UI changes, add before/after screenshots. For interactive elements,
consider including a video or an animated gif.
Explain some of the choices you've made in the PR, if they're not
obvious.
-->

### Testing this change

<!--
Describe how this change can be tested. Are there steps required to get
there? Explain what's required so a reviewer can test these changes
locally.

  If you have a review link available, add it here.
-->

### Additional Notes (if any)

<!--
  Add any other context or screenshots about the pull request
-->


https://github.com/tokens-studio/figma-plugin/assets/103296157/62e1d675-0d85-4d1f-84a8-44faaa1baa4f

---------

Co-authored-by: Luke Finch <lukechristianfinch@gmail.com>
Co-authored-by: Jan Six <six.jan@gmail.com>
@six7 six7 closed this as completed Apr 30, 2024
@github-project-automation github-project-automation bot moved this from 🕜 In Progress to ✅ Done in Tokens Studio for Figma Roadmap Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@six7 six7

Labels
bug Something isn't working ❇️ Featurebase Roadmap Issue was added to a featurebase roadmap post Figma export Previously create and sync styles variables Figma variables plugin v2 variables, UI, WTCG format, Bitbucket token name
Projects
Tokens Studio for Figma Roadmap
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2645 20 rename variables non functional 1 tokens-studio/figma-plugin
4 participants
@six7 @LukeFinch @robinhoodie0823 @SamIam4Hyma