Fix/ min&max width&height on instances #2842
Conversation
|
LukeFinch
changed the title
| @@ -54,8 +53,6 @@ export async function applySizingValuesOnNode( | |||
| if ( | |||
| node.type !== 'DOCUMENT' | |||
| && node.type !== 'PAGE' | |||
| && node.type !== 'INSTANCE' | |||
| && !isPartOfInstance(node.id) | |||
There was a problem hiding this comment.
I think this part here needs to stay in - we cant apply min max width tokens on instance children, this would throw an error
There was a problem hiding this comment.
as in just the isPartofInstance needs to stay in
There was a problem hiding this comment.
If this stays, then this is not the fully fledged fix? Can't see any other changes 😅
There was a problem hiding this comment.
It basically just resolves the case descrbied in the issue: if the layer itself is an instance, we want to allow setting sizing related tokens (as this is possibly). However, if its part of an instance this wouldnt work because figma doesnt allow it.
Why does this PR exist?
Closes #2426
What does this pull request do?
Changes the logic to apply min and max-width on instances
Testing this change
Create a component with autolayout
Create an instance of the component
Apply min/max width/height sizing through the plugin
Additional Notes (if any)