2837 20 unable to create variable collections from sets #2844
Conversation
|
| @@ -30,6 +30,18 @@ export default async function createLocalVariablesWithoutModesInPlugin(tokens: R | |||
|
|
|||
| const checkSetting = !settings.variablesBoolean && !settings.variablesColor && !settings.variablesNumber && !settings.variablesString; | |||
| if (!checkSetting) { | |||
| const themesToCreateCollections = selectedSets.reduce((acc: ThemeObject[], curr: ExportTokenSet) => { | |||
There was a problem hiding this comment.
would you not be able to re-use the themeContainer const on line 45 for this? I think thats what it was intended for?
| const { collection, modeId } = findCollectionAndModeIdForTheme(set.set, set.set, collections); | ||
|
|
||
| if (!collection || !modeId) return; | ||
|
|
||
| const allVariableObj = await updateVariables({ | ||
| collection, mode: modeId, theme: themeContainer, tokens: setTokens, settings, filterByTokenSet: set.set, | ||
| collection, mode: modeId, theme: themeContainer, tokens, settings, filterByTokenSet: set.set, |
There was a problem hiding this comment.
I think this part here is whats causing an issue when multiple sets have the same tokens. For example, load up the Preset, and then activate each set. Try to create variables based on sets. Notice that the light set is going to be empty.
Why does this PR exist?
Current plugin does not create local variable collections based on selected token sets. Because the
createNecessaryVariableCollectionsfunction does not accept the parameter structure in case of selected sets.Closes #2837
What does this pull request do?
Updated
createLocalVariablesWithoutModesInPluginfunction to send parameters with the structure whichcreateNecessaryVariableCollectionsfunction can accept to proceed.Testing this change
Additional Notes (if any)
20240611_203716.mp4