fix: clicking a select when editing a color token now keeps the modal open #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuserox
added
bug
|
cuserox
force-pushed
the
fix/2885-outside-select-click-now-keeps-modal-open
branch
2 times, most recently
from
dd8de40
to
364ddd2
Compare
…orary fix for radix related bug
cuserox
force-pushed
the
fix/2885-outside-select-click-now-keeps-modal-open
branch
from
364ddd2
to
2d30fad
Compare
|
🥼 Closing in favour of more testing on the DS: https://github.com/tokens-studio/ds/pull/222 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why does this PR exist?
Closes #2885
When editing a color token, specifically the Modify operations, when clicking outside either of the
Selectcomponents - still within theDialog- it would close the whole modal!What does this pull request do?
EditTokenFormModalto be a true Dialog by reverting this line (nowmodal={true}as per Radix's Dialog default prop)Selectcontained in aDialog) seems to dees the underlying layer unresponsive due topointer-events: noneremaining in the<body>= Radix bug! This mitigates it as a temporary fix on theEditTokenFormModal.tsx. Some thoughts:DropdownMenus/Select&Dialogto the latest Radix UI versions - then they went for a temporary fix:pointer-eventsto auto (Community suggestions: [Dialog] body pointer-events: none remains after closing radix-ui/primitives#1241 (comment) & [Dialog] body pointer-events: none remains after closing radix-ui/primitives#1241 (comment))Testing this change
+) Modify to set an Operation or Space (see 2 Select components)clickingOutsideModifierSelectsClosesTheModal.mp4
clickingOutsideTheSelectModifiersDontCloseTheModal.mp4