Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom linear gradient angles #3109

Merged
merged 13 commits into from
Dec 10, 2024

Conversation

macintoshhelper
Copy link
Contributor

@macintoshhelper macintoshhelper commented Aug 30, 2024

Why does this PR exist?

Partial fix for #2331

What does this pull request do?

Before

image

After

image

Testing this change

Additional Notes (if any)

Copy link

changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: d73493c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 30, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Commit SHA:7e9b1d34295bbf94e23b29d26899e7e3e859fce2

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix/2331-custom-angle-linear-gradients 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 67.07 (0.02) 57.94 (0) 63.9 (0.01) 67.42 (0.03)
🟢 packages/tokens-studio-for-figma/src/plugin/figmaTransforms/gradients.ts 75 (5) 55 (-2.89) 100 (0) 74.6 (5.22)

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Commit SHA:7e9b1d34295bbf94e23b29d26899e7e3e859fce2
Current PR reduces the test coverage percentage by 1 for some tests

@macintoshhelper macintoshhelper marked this pull request as ready for review September 5, 2024 10:54
@six7
Copy link
Collaborator

six7 commented Oct 15, 2024

@macintoshhelper linting seems to have failed here

@macintoshhelper
Copy link
Contributor Author

Fixed the ESLint errors

@qimmiq
Copy link

qimmiq commented Dec 5, 2024

Since September, tbh this bug is so frustrating ... also to see that there is fix and every release since then does not include that fix :(

@akshay-gupta7
Copy link
Contributor

akshay-gupta7 commented Dec 5, 2024

Since September, tbh this bug is so frustrating ... also to see that there is fix and every release since then does not include that fix :(

@qimmiq sorry about the miss in this one 😊
I will take a look at this PR and will keep you posted on it's progress

@rbosker rbosker added token type gradient Not a type yet but exists in DTCG W3C needs-responder labels Dec 9, 2024
@akshay-gupta7 akshay-gupta7 merged commit 41f7e34 into main Dec 10, 2024
9 of 10 checks passed
@akshay-gupta7 akshay-gupta7 deleted the fix/2331-custom-angle-linear-gradients branch December 10, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-responder token type gradient Not a type yet but exists in DTCG W3C
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants