Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling issue with prefixed theme name #3153

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

akshay-gupta7
Copy link
Contributor

@akshay-gupta7 akshay-gupta7 commented Sep 24, 2024

Fixes #3145

Description

Fixes a bug around applying styles with prefixed theme name, where if the user applies core theme, then it mangles with the application of styles display in the plugin.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • None of the above

How to test this

  • Create themes in the plugin
  • Export them as styles with prefixed theme name
  • Apply a color token from a theme, it will reflect the style in Figma
  • Now disable core style and it should work then

Screenshots or video (if necessary):

Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 7ed065e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 24, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

github-actions bot commented Sep 24, 2024

Commit SHA:531f5e3a09003e551c70e02f66f5fbd117cca06a
No changes to code coverage between the base branch and the head branch

@akshay-gupta7 akshay-gupta7 marked this pull request as ready for review September 25, 2024 06:33
@akshay-gupta7 akshay-gupta7 self-assigned this Sep 25, 2024
@akshay-gupta7 akshay-gupta7 merged commit bf8c185 into main Sep 25, 2024
9 checks passed
@akshay-gupta7 akshay-gupta7 deleted the fix-prefix-themes-styles branch September 25, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles aren't Applied with Prefix Styles with Theme name
2 participants