Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change sets zero padding #3162

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

macintoshhelper
Copy link
Contributor

Why does this PR exist?

Fixes #2699

What does this pull request do?

Removes full prop which sets padding to 0: https://github.com/tokens-studio/figma-plugin/compare/fix/2699-change-sets-padding?expand=1#diff-86ff146cc232d5b481858fd012daa944ea3ae8d58613e89e22f0da6efa31908cL147

Before

image

After

image

Testing this change

Additional Notes (if any)

Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: 4eff027

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 3, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

import {
Tabs, Stack, Heading, Button,
} from '@tokens-studio/ui';
import { Tabs, Stack, Heading, Button } from '@tokens-studio/ui';

Check failure

Code scanning / ESLint

enforce consistent line breaks after opening and before closing braces Error

Expected a line break after this opening brace.
import {
Tabs, Stack, Heading, Button,
} from '@tokens-studio/ui';
import { Tabs, Stack, Heading, Button } from '@tokens-studio/ui';

Check failure

Code scanning / ESLint

enforce consistent line breaks after opening and before closing braces Error

Expected a line break before this closing brace.
control={control}
// this is the only way to do this
// eslint-disable-next-line
render={({ field }) => <TokenSetThemeItem {...props} value={field.value} onChange={field.onChange} />}

Check failure

Code scanning / ESLint

Disallow `.bind()` or arrow functions in JSX props Error

JSX props should not use arrow functions
{allSets.length}
{' '}
{t('exportSetsTab.setsSelectedForExport')}
{allSets.length} {t('exportSetsTab.setsSelectedForExport')}

Check failure

Code scanning / ESLint

Require one JSX element per line Error

{t('exportSetsTab.setsSelectedForExport')} must be placed on a new line
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Commit SHA:525f8fad4fac02e02fe2b8d9ffde2413dc6c27a8
No changes to code coverage between the base branch and the head branch

@macintoshhelper macintoshhelper marked this pull request as ready for review October 7, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0]: Change sets padding
1 participant