Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate display studio sync #3171

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akshay-gupta7
Copy link
Contributor

Resolves #3069

Fixes an error where the Tokens Studio Sync Provider in the plugin was showing up twice.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • None of the above

How to test this

  • Go to Settings Tab
  • Click on Add New Sync Provider
  • Choose Tokens Studio(Beta)
  • Add API key and connection string
  • Click on Save
  • You should either see and error or a success. If you see an error, check your keys and click on save again. If successful, the Tokens Studio Sync provider should no show up only once in the list of sync providers

Screenshots or video (if necessary):

@akshay-gupta7 akshay-gupta7 self-assigned this Oct 10, 2024
Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: 8811070

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

Commit SHA:32e72676f2134fd4e122073c2729dcd2c36e0c3d

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix-duplicate-display-studio-sync 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 67.88 (-0.03) 58.47 (0) 64.65 (-0.02) 68.27 (-0.02)
🔴 packages/tokens-studio-for-figma/src/app/components/StorageItemForm/TokensStudioForm.tsx 4 (-0.76) 0 (0) 0 (0) 4.16 (-0.84)

Copy link
Contributor

Commit SHA:32e72676f2134fd4e122073c2729dcd2c36e0c3d
Current PR reduces the test coverage percentage by 1 for some tests

Copy link
Collaborator

@six7 six7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesnt fix the issue for already duplicative registered providers. Also, the issue mentions this also happens for other sync providers such as Supernova, can you check that as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync: Plugin is showing connection twice
2 participants