Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope the typography shorthand to CSS #20

Merged
merged 8 commits into from
Feb 17, 2023

Conversation

germain-gg
Copy link
Contributor

Fixes #17

Also adds a typography shorthand transformer for Jetpack Compose. It uses TextStyle and maps the properties of the typography tokens to the properties in Compose.

I could not find a way to match paragraphSpacing, it therefore is skipped.

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2023

🦋 Changeset detected

Latest commit: 6c39f60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/sd-transforms Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

germain-gg added a commit to element-hq/compound-design-tokens that referenced this pull request Feb 15, 2023
Copy link
Member

@jorenbroekema jorenbroekema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code-style comment is optional (not a blocker)
The changeset one is necessary though :)

Thanks again for the PR!

src/compose/transformTypography.js Outdated Show resolved Hide resolved
.changeset/purple-falcons-knock.md Outdated Show resolved Hide resolved
@jorenbroekema
Copy link
Member

Ah also run a npm run format, will usually fix the linting/formatting issues automatically.

@jorenbroekema jorenbroekema merged commit d4d2bc2 into tokens-studio:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespacing transform to target language
2 participants