Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to syn 2.0 #93

Merged
merged 7 commits into from
Apr 5, 2023
Merged

Update to syn 2.0 #93

merged 7 commits into from
Apr 5, 2023

Conversation

davidpdrsn
Copy link
Member

No description provided.

@davidpdrsn davidpdrsn requested a review from taiki-e March 18, 2023 18:07
taiki-e
taiki-e reviewed Mar 18, 2023
View reviewed changes
async-stream-impl/src/lib.rs Outdated Show resolved Hide resolved
async-stream-impl/src/lib.rs Outdated Show resolved Hide resolved
@davidpdrsn davidpdrsn requested a review from taiki-e March 20, 2023 19:56
@davidpdrsn
Copy link
Member Author

CI fails because syn's MSRV is now 1.56

@davidpdrsn davidpdrsn requested a review from taiki-e March 21, 2023 09:03
@taiki-e
Copy link
Member

taiki-e commented Mar 22, 2023

LGTM. As for MSRV, I think bumping it to 1.56 is fine. Modern proc macros that depend on syn 2 need it anyway

This was referenced Apr 4, 2023
Closed
Merged
@taiki-e
Copy link
Member

taiki-e commented Apr 4, 2023

MSRV has been bumped in #97.

taiki-e
taiki-e approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 56a7608 into master Apr 5, 2023
@taiki-e taiki-e deleted the dp/syn-2 branch April 5, 2023 13:42
@taiki-e taiki-e mentioned this pull request Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidpdrsn @taiki-e