Panic on overlapping routes in MethodRouter
#1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jun 18, 2022
|
It does work already but I added tests just to make sure. It works because we only override the corresponding service so doing |
jplatte
approved these changes
Jun 18, 2022
davidpdrsn
added a commit
that referenced
this pull request
Jun 25, 2022
* Panic on overlapping routes in `MethodRouter` * changelog link * add test to ensure `head` and `get` don't overlap
davidpdrsn
added a commit
that referenced
this pull request
Jun 25, 2022
* Panic on overlapping routes in `MethodRouter` * changelog link * add test to ensure `head` and `get` don't overlap
davidpdrsn
added a commit
that referenced
this pull request
Jun 27, 2022
* Panic on overlapping routes in `MethodRouter` * changelog link * add test to ensure `head` and `get` don't overlap
davidpdrsn
added a commit
that referenced
this pull request
Jun 28, 2022
* Panic on overlapping routes in `MethodRouter` * changelog link * add test to ensure `head` and `get` don't overlap
davidpdrsn
added a commit
that referenced
this pull request
Jun 28, 2022
* Panic on overlapping routes in `MethodRouter` * changelog link * add test to ensure `head` and `get` don't overlap
davidpdrsn
added a commit
that referenced
this pull request
Jun 29, 2022
* Prepare axum-next branch * Remove deprecated `extractor_middleware` function (#1077) * Allow `Error: Into<Infallible>` for `Route::{layer, route_layer}` (#948) * Allow `Error: Into<Infallible>` for `Route::{layer, route_layer}` (#924) * Allow `Error: Into<Infallible>` for `Route::{layer, route_layer}` Fixes #922 * changelog * fixup changelog * Panic on overlapping routes in `MethodRouter` (#1102) * Panic on overlapping routes in `MethodRouter` * changelog link * add test to ensure `head` and `get` don't overlap * Fix changelog * Prepare axum-next branch * Remove trailing slash redirects * changelog link * Fix changelog * remove asserting to make make the test more clear * remove tsr related feature * Add `RouterExt::route_with_tsr` * Apply suggestions from code review Co-authored-by: Jonas Platte <jplatte+git@posteo.de> * Update axum-extra/src/routing/mod.rs Co-authored-by: Jonas Platte <jplatte+git@posteo.de> * fix typos in docs * Update axum/CHANGELOG.md Co-authored-by: Jonas Platte <jplatte+git@posteo.de> * mention `RouterExt::route_with_tsr` in the changelog Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
get(foo).get(bar)panic, similarly toRouter::route.Fixes #1097