Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unhelpful compiler suggestion #1251

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Aug 12, 2022

No description provided.

@jplatte jplatte requested a review from davidpdrsn August 12, 2022 09:54
@davidpdrsn davidpdrsn enabled auto-merge (squash) August 12, 2022 09:57
@jplatte
Copy link
Member Author

jplatte commented Aug 12, 2022

I think it's actually kind of wrong to say we don't support generic functions, it's just that we can't fully check them. Also we could check input types that don't mention any of the generic parameters, but that's non-trivial and might not be worth the time needed to implement it.

I've had an idea for a while that would make generic handlers pretty much fully checkable, that is:

#[debug_handler(with(T = String, T = u64; U = i8, U = i16; N = 0))]
fn handler<T, U, const N: usize>(extract_t: Path<T>, extract_u: Json<U>, extract_n: Foo<N>)
where
    T: Deserialize,
    U: Deserialize,
{
    // ...
}

could make debug_handler add FromRequest assertions for Path<String>, Path<u64>, Json<i8>, Json<i16> and Foo<0> while also adding Send assertions for the futures returned by

  • handler::<String, i8, 0>
  • handler::<String, i16, 0>
  • handler::<u64, i8, 0>
  • handler::<u64, i16, 0>

If we were to do that, we could just require users to add this with() annotation before any parameters are checked on a generic function (even ones that don't mention the generic types) as it should be easy enough.

@davidpdrsn davidpdrsn merged commit 7795e64 into main Aug 12, 2022
@davidpdrsn davidpdrsn deleted the jplatte/compiler-error branch August 12, 2022 10:06
davidpdrsn pushed a commit that referenced this pull request Aug 12, 2022
davidpdrsn added a commit that referenced this pull request Aug 17, 2022
* begin threading the state through

* Pass state to extractors

* make state extractor work

* make sure nesting with different states work

* impl Service for MethodRouter<()>

* Fix some of axum-macro's tests

* Implement more traits for `State`

* Update examples to use `State`

* consistent naming of request body param

* swap type params

* Default the state param to ()

* fix docs references

* Docs and handler state refactoring

* docs clean ups

* more consistent naming

* when does MethodRouter implement Service?

* add missing docs

* use `Router`'s default state type param

* changelog

* don't use default type param for FromRequest and RequestParts

probably safer for library authors so you don't accidentally forget

* fix examples

* minor docs tweaks

* clarify how to convert handlers into services

* group methods in one impl block

* make sure merged `MethodRouter`s can access state

* fix docs link

* test merge with same state type

* Document how to access state from middleware

* Port cookie extractors to use state to extract keys (#1250)

* Updates ECOSYSTEM with a new sample project (#1252)

* Avoid unhelpful compiler suggestion (#1251)

* fix docs typo

* document how library authors should access state

* Add `RequestParts::with_state`

* fix example

* apply suggestions from review

* add relevant changes to axum-extra and axum-core changelogs

* Add `route_service_with_tsr`

* fix trybuild expectations

* make sure `SpaRouter` works with routers that have state

* Change order of type params on FromRequest and RequestParts

* reverse order of `RequestParts::with_state` args to match type params

* Add `FromRef` trait (#1268)

* Add `FromRef` trait

* Remove unnecessary type params

* format

* fix docs link

* format examples

* Avoid unnecessary `MethodRouter`

* apply suggestions from review

Co-authored-by: Dani Pardo <dani.pardo@inmensys.com>
Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
davidpdrsn pushed a commit that referenced this pull request Sep 10, 2022
davidpdrsn added a commit that referenced this pull request Sep 10, 2022
* Limit size of request bodies in `Bytes` extractor (#1346)

* Apply default limit to request body size

* Support disabling the default limit

* docs

* changelog

* fix doc test

* fix docs links

* Avoid unhelpful compiler suggestion (#1251)

Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants