Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rest-grpc-multiplex example to include reflection #1902

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Update rest-grpc-multiplex example to include reflection #1902

merged 1 commit into from
Apr 1, 2023

Conversation

davidpdrsn
Copy link
Member

@davidpdrsn davidpdrsn commented Apr 1, 2023 •
edited
Loading

This updates the rest-grpc-multiplex example to also include setup for
tonic-reflection. Unless you're familiar with all the pieces its not very
easy to do so figured it makes sense to include in the example.

Context: #1840

@davidpdrsn davidpdrsn requested a review from jplatte April 1, 2023 10:17
@davidpdrsn davidpdrsn enabled auto-merge (squash) April 1, 2023 10:18
@davidpdrsn davidpdrsn mentioned this pull request Apr 1, 2023
Closed
jplatte
jplatte approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing about grpc / tonic, but doesn't look crazy 😅

@davidpdrsn davidpdrsn merged commit 24f8dc5 into main Apr 1, 2023
@davidpdrsn davidpdrsn deleted the david/grpc-reflection branch April 1, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidpdrsn @jplatte