Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove buffer from BoxRoute (#270)" #273

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Revert "Remove buffer from BoxRoute (#270)" #273

merged 1 commit into from
Aug 26, 2021

Conversation

davidpdrsn
Copy link
Member

This reverts commit 552d69e.

It turns out that #270 made BoxRoute !Sync which made one of our project's at Embark not compile. Gonna revert, publish new release, and then yank.

@davidpdrsn davidpdrsn enabled auto-merge (squash) August 26, 2021 14:05
@davidpdrsn davidpdrsn merged commit a0be328 into main Aug 26, 2021
@davidpdrsn davidpdrsn deleted the revert-clone-box-service branch August 26, 2021 14:11
@davidpdrsn davidpdrsn mentioned this pull request Aug 26, 2021
Merged
davidpdrsn added a commit that referenced this pull request Aug 26, 2021
@davidpdrsn
Version 0.2.3 (#274)
bdc39de 
0.2.3 (26. August, 2021)

- **fixed:** Fix accidental breaking change introduced by internal refactor.
  `BoxRoute` used to be `Sync` but was accidental made `!Sync` ([#273](#273))
@davidpdrsn davidpdrsn mentioned this pull request Aug 26, 2021
Closed
@davidpdrsn davidpdrsn mentioned this pull request Oct 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidpdrsn