Replace Router::{map_inner, tap_inner_mut} by macros #2954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… so that #[track_caller] works.
Adding #[track_caller] to the two functions would not have the same effect as the closures passed to both would also need the attribute, but it's currently not supported on closures:
rust-lang/rust#87417
Motivation
We use
#[track_caller]
in a few places where we panic on invalid user input, to have the panic message point at the relevant method call in the user's code. A few of those, including the one for the new routing syntax, don't work as intended; the panic message still points at something inside axum.Solution
Replace the internal helpers that break
#[track_caller]
by macros.