Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded #[allow] attributes #2995

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Remove unneeded #[allow] attributes #2995

merged 2 commits into from
Oct 17, 2024

Conversation

bengsparks
Copy link
Contributor

Motivation

Cleanup from work done in #2904.

Solution

Remove all warning suppressions related to unreachable patterns, now that an exception for empty match arms has been made and backported to beta

$ c +stable b 
   Compiling axum v0.8.0-alpha.1 (/private/tmp/axum/axum)
   Compiling axum-extra v0.10.0-alpha.1 (/private/tmp/axum/axum-extra)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.92s

$ c +beta b  
   Compiling axum v0.8.0-alpha.1 (/private/tmp/axum/axum)
   Compiling axum-extra v0.10.0-alpha.1 (/private/tmp/axum/axum-extra)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.28s

$ c +nightly b
   Compiling axum v0.8.0-alpha.1 (/private/tmp/axum/axum)
   Compiling axum-extra v0.10.0-alpha.1 (/private/tmp/axum/axum-extra)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.30s

Benjamin Sparks added 2 commits October 17, 2024 16:14
Copy link
Collaborator

@mladedav mladedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this!

@mladedav mladedav merged commit c5a451d into tokio-rs:main Oct 17, 2024
18 checks passed
@jplatte
Copy link
Member

jplatte commented Oct 17, 2024

I was a bit confused when seeing the PR title - I don't see the builtin #[allow] attribute as a macro (no idea whether it is implemented as one). I'll update the PR title just so it's a bit more obvious (even though it's already merged).

@jplatte jplatte changed the title Remove unneeded macro usage Remove unneeded #[allow] attributes Oct 17, 2024
jplatte pushed a commit that referenced this pull request Nov 14, 2024
Co-authored-by: Benjamin Sparks <b.sparks@alugha.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants