-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name of Buf::to_bytes does not follow self conventions #398
Milestone
Comments
Hm, it is true it doesn't follow that convention (though I don't think that's too big a deal in itself). I don't think of any convenient other names that explain what it does. Possibly something like |
carllerche
added a commit
that referenced
this issue
Oct 20, 2020
Fixed by #439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
An inherent method with the signature of
Buf::to_bytes
would not pass clippy:In the next breaking release, consider renaming the method or maybe replace it with #129 (though less deceptively named than
copy_to_bytes
).The text was updated successfully, but these errors were encountered: