Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does Option<[u8; 1]> implement Buf? #444

Closed
KamilaBorowska opened this issue Nov 25, 2020 · 2 comments · Fixed by #449
Closed

Why does Option<[u8; 1]> implement Buf? #444

KamilaBorowska opened this issue Nov 25, 2020 · 2 comments · Fixed by #449
Milestone
v1.0

Comments

@KamilaBorowska
Copy link

KamilaBorowska commented Nov 25, 2020 •
edited
Loading

Buf trait has a rather curious implementation for Option<[u8; 1]> which was introduced in #72. I don't think it's particularly useful and currently there are no tests of it working to begin with (if I remove this implementation which has no doc comments the tests still pass). I think it could be removed in 1.0 (or 0.7 I suppose).
@seanmonstar
Copy link
Member

I see very little value in the implementation. I'd be fine with removing it.

@Darksonn
Copy link
Contributor

It seems to have been used for an impl IntoBuf for u8, but I'm not sure IntoBuf still exists?

@carllerche carllerche added this to the v1.0 milestone Nov 25, 2020
carllerche added a commit that referenced this issue Dec 17, 2020
@carllerche
remove unused Buf implementation.
0a1664f 
The implementation of `Buf` for `Option<[u8; 1]>` was added to support
`IntoBuf`. The `IntoBuf` trait has since been removed.

Closes #444
@carllerche carllerche mentioned this issue Dec 17, 2020
Merged
carllerche added a commit that referenced this issue Dec 17, 2020
@carllerche
remove unused Buf implementation. (#449)
54f5ced 
The implementation of `Buf` for `Option<[u8; 1]>` was added to support
`IntoBuf`. The `IntoBuf` trait has since been removed.

Closes #444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

remove unused Buf implementation. tokio-rs/bytes
4 participants
@carllerche @seanmonstar @Darksonn @KamilaBorowska