Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build fail with serde feature #293

Merged
merged 3 commits into from
Sep 8, 2019
Merged

Fix build fail with serde feature #293

merged 3 commits into from
Sep 8, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Sep 8, 2019 •
edited
Loading

And added check to CI.

Also, fix build fail with --no-default-features (bbf7785)

DoumanAsh
DoumanAsh approved these changes Sep 8, 2019
View reviewed changes
Copy link
Contributor

@DoumanAsh DoumanAsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing it

ci/azure-test-stable.yml Show resolved Hide resolved
@DoumanAsh DoumanAsh merged commit ebe9602 into tokio-rs:master Sep 8, 2019
@DoumanAsh
Copy link
Contributor

Thanks

@taiki-e taiki-e deleted the serde branch September 8, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoumanAsh DoumanAsh DoumanAsh approved these changes

@carllerche carllerche Awaiting requested review from carllerche

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @DoumanAsh