Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subscriber: consider adding filter env var builder parameter #206

Closed
hawkw opened this issue Dec 15, 2021 · 0 comments · Fixed by #276
Closed

subscriber: consider adding filter env var builder parameter #206

hawkw opened this issue Dec 15, 2021 · 0 comments · Fixed by #276
Labels
C-subscriber Crate: console-subscriber. E-easy Effort: easy. Good for newcomers S-feature Severity: feature. This is adding a new feature.

Comments

@hawkw
Copy link
Member

hawkw commented Dec 15, 2021

what do you think about making the filter environment variable a builder parameter? so, by default, it uses RUST_LOG, but there's a separate builder method to change the filter env var? something like:

let console = console_subscriber::Builder::new()
   .with_filter_env_variable("MYAPP_LOG")
   .build_console_layer();

Originally posted by @hawkw in #195 (comment)
@hawkw hawkw added C-subscriber Crate: console-subscriber. E-easy Effort: easy. Good for newcomers S-feature Severity: feature. This is adding a new feature. labels Dec 15, 2021
mujpao added a commit to mujpao/console that referenced this issue Feb 8, 2022
@mujpao
feat(subscriber) add filter env var builder parameter
a77c6f4 
Add a new builder method to `console_subscriber::Builder` to configure
the filter environment variable to use for `tracing` events.

closes tokio-rs#206
@mujpao mujpao mentioned this issue Feb 8, 2022
Merged
hawkw added a commit that referenced this issue Feb 18, 2022
@mujpao @hawkw
feat(subscriber): add Builder::filter_env_var builder parameter (#276)
dbdb149 
Add a new builder method to `console_subscriber::Builder` to configure
the filter environment variable to use for `tracing` events.

Closes #206

Co-authored-by: Eliza Weisman <eliza@buoyant.io>
hawkw added a commit that referenced this issue Feb 18, 2022
@hawkw
chore(subscriber): prepare to release v0.1.3
398cbcf 
#### Features

*  add `Builder::filter_env_var` builder parameter (#276)
   ([dbdb149](dbdb149), closes [#206](206))

#### Bug Fixes

*  record timestamps for updates last (#289) ([703f1aa](703f1aa),
   closes [#266](266))
*  use monotonic `Instant`s for all timestamps (#288)
   ([abc0830](abc0830), closes [#286](286))
*  bail rather than panic when encountering clock skew (#287)
   ([24db8c6](24db8c6), closes [#286](286))
*  fix compilation on targets without 64-bit atomics (#282)
   ([5590fdb](5590fdb), closes [#279](279))
hawkw added a commit that referenced this issue Feb 18, 2022
@hawkw
chore(subscriber): prepare to release v0.1.3 (#292)
0e67d17 
#### Features

*  add `Builder::filter_env_var` builder parameter (#276)
   ([dbdb149](dbdb149), closes [#206](206))

#### Bug Fixes

*  record timestamps for updates last (#289) ([703f1aa](703f1aa),
   closes [#266](266))
*  use monotonic `Instant`s for all timestamps (#288)
   ([abc0830](abc0830), closes [#286](286))
*  bail rather than panic when encountering clock skew (#287)
   ([24db8c6](24db8c6), closes [#286](286))
*  fix compilation on targets without 64-bit atomics (#282)
   ([5590fdb](5590fdb), closes [#279](279))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-subscriber Crate: console-subscriber. E-easy Effort: easy. Good for newcomers S-feature Severity: feature. This is adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(subscriber) add filter env var builder parameter mujpao/console
1 participant
@hawkw