Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--ascii-only is flipped #372

Closed
lior2b opened this issue Aug 27, 2022 · 0 comments · Fixed by #377
Closed

--ascii-only is flipped #372

lior2b opened this issue Aug 27, 2022 · 0 comments · Fixed by #377
Labels
C-console Crate: console. E-easy Effort: easy. Good for newcomers S-bug Severity: bug

Comments

@lior2b
Copy link

lior2b commented Aug 27, 2022

What crate(s) in this repo are involved in the problem?

tokio-console

What is the issue?

See repro

How can the bug be reproduced?

tokio-console --ascii-only true shows emojis
tokio-console --ascii-only false shows ascii

Logs, error output, etc

No response

Versions

0.1.7

Possible solution

clap crate has a default_value feature, makes the code cleaner and documents the defaults in the help message

Additional context

No response

Would you like to work on fixing this bug?

no
@lior2b lior2b added the S-bug Severity: bug label Aug 27, 2022
@hawkw hawkw added E-easy Effort: easy. Good for newcomers C-console Crate: console. labels Aug 27, 2022
michealkeines added a commit to michealkeines/console that referenced this issue Sep 6, 2022
@michealkeines
fix(console): fix ascii-only flipped input
56323ac 
`--ascii-only true` shows ascii
`--ascii-only false` shows emojis
default value: true shows emojis

Fixes: tokio-rs#372
@michealkeines michealkeines mentioned this issue Sep 6, 2022
Merged
@hawkw hawkw closed this as completed in #377 Sep 7, 2022
hawkw pushed a commit that referenced this issue Sep 7, 2022
@michealkeines
fix(console): fix ascii-only flipped input (#377)
da0e972 
Fixes: #372

`--ascii-only true` shows ascii
`--ascii-only false` shows emojis

if `--ascii-only` is not passed, default value will be true, shows emojis
hawkw pushed a commit that referenced this issue Sep 29, 2023
@michealkeines @hawkw
fix(console): fix ascii-only flipped input (#377)
652ac34 
Fixes: #372

`--ascii-only true` shows ascii
`--ascii-only false` shows emojis

if `--ascii-only` is not passed, default value will be true, shows emojis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-console Crate: console. E-easy Effort: easy. Good for newcomers S-bug Severity: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(console): fix ascii-only flipped input michealkeines/console
2 participants
@lior2b @hawkw