feat(console): Add vi style keybinds for navigating tables

[k0nserv]

Adds hjkl as alternatives to the arrow keys and G and gg to navigate
to the first and last rows in tables, respectively.

Changes to the UI:

[hawkw]

nice, i'm sure this will make a lot of people very happy! :)

we also display the keybindings in the UI, so maybe we should also add the vi-style keybindings to the table controls we display, here:

console/console/src/view/table.rs

Lines 162 to 176 in 1aa9b59

	pub(in crate::view) fn controls(styles: &view::Styles) -> Text {
	tui::text::Text::from(Spans::from(vec![
	Span::raw("controls: "),
	bold(styles.if_utf8("\u{2190}\u{2192}", "left, right")),
	text::Span::raw(" = select column (sort), "),
	bold(styles.if_utf8("\u{2191}\u{2193}", "up, down")),
	text::Span::raw(" = scroll, "),
	bold(styles.if_utf8("\u{21B5}", "enter")),
	text::Span::raw(" = view details, "),
	bold("i"),
	text::Span::raw(" = invert sort (highest/lowest), "),
	bold("q"),
	text::Span::raw(" = quit"),
	]))
	}

also, I wonder if it's worth making a CLI option for toggling between vi only, arrow keys only, and enabling both? but, we could also do that in a follow-up PR.

[k0nserv]

Thanks for the suggestions, I considered both those options as I wrote this.

For adding the bindings to the UI I wasn't sure how to do it so I wanted to raise it here instead.

One possibility is \u{2190}(h)\u{2192}(l) for left/right and likewise for up and down. I'm happy to add this, my concern was that it might be a bit messy. I guess for G and gg those could just be added directly.

e.g. like this

An option to consider if this display of keybinding does get too unwieldy is ? to bring up a floating window that displays them all.

About the CLI toggling: My thinking was there's no harm in having both by default, folks will use the ones they know/prefer? I'm not sure there's any benefit to allowing them to be disabled, but I can certainly add that in a follow up PR if you wish

[hawkw]

One possibility is \u{2190}(h)\u{2192}(l) for left/right and likewise for up and down.

How about \u{2190}/\u{2192} or h/l and similar, instead? (ideally, with the or and the slashes not bolded). But, honestly, I'm fine with whatever. I think just displaying gg and G separately the way you did in your screenshot looks correct.

An option to consider if this display of keybinding does get too unwieldy is ? to bring up a floating window that displays them all.

Yeah, that might be a good idea, especially if we add more controls for things like filtering (#131) in the future. A simpler solution might just be to make it two lines rather than one line, but that eats up more vertical real estate...

About the CLI toggling: My thinking was there's no harm in having both by default, folks will use the ones they know/prefer? I'm not sure there's any benefit to allowing them to be disabled, but I can certainly add that in a follow up PR if you wish

Honestly, the only real benefit I had in mind is that it makes the controls list shorter to disable one set of keybindings :) I really don't think people are likely to disable or enable keybindings with a command-line option. I think that if we eventually add a config file, it might be more likely to want to configure keybindings there, but in that case, I'd imagine users would want to specify custom keybindings, rather than just turning them on or off. All of that is just something to think about for the future, though.

Once we've added the vi keybindings to the table controls, I'll be happy to merge this!

[k0nserv]

Here's what it looks like now

[hawkw]

Here's what it looks like now

Yup, that looks good to me. I noticed that the controls line is now quite long, and probably won't fit in a narrower terminal...and that we truncate the line instead of wrapping it. So, I went ahead and implemented wrapping in PR #231, so that we can add more text to the controls and still have it display nicely on narrower terminals. Once that's merged, let's go ahead and merge this PR!

[hawkw]

@k0nserv any updates here? It would be nice to get this updated with the latest main branch, and then I'll be happy to merge it!

[k0nserv]

I saw that you had merged main into this branch and I thought you'd merge when #231 was merged.

What do you need me to do before we can merge?

[hawkw]

What do you need me to do before we can merge?

It looks like the change for adding the keybindings to the help text hasn't actually been added to this branch yet? Once that's done, I'll merge this.

[k0nserv]

Huh, I thought I pushed that, but I guess not then. Shall resolve

[k0nserv]

Rebased on main and pushed now

[k0nserv]

I believe you need to approve the some of the workflows for them to run

[hawkw]

okay, looks good to me! thanks again for working on this!

[k0nserv]

Thanks for merging 👍